Configurable maximum reconnection attempts - #174
Closed
terrettaz wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
zmarkan
reviewed
Feb 21, 2018
Comment thread
src/main/java/com/pusher/client/PusherOptions.java
| private Authorizer authorizer; | ||
| private Proxy proxy = Proxy.NO_PROXY; | ||
| private int maxReconnectionAttempts = MAX_RECONNECTION_ATTEMPTS; | ||
| private int maxReconnectGabInSeconds = MAX_RECONNECT_GAP_IN_SECONDS; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
should be gap not gab
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Looks good, I'll merge and release today, thanks. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I've fixed the typo and issued another PR. Closing this one. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@terrettaz I've just released this and it should propagate in maven central in a matter of hours - the version will be 1.8.0. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the pull request
To make configurable the connection number of reconnection attempts.
Why is the change necessary?
In a server-mode use, hard-coded 6 reconnection attempts is not enough.
CC @pusher/mobile