Don't reconnect when codes in 40xx range are received - #187
Merged
kn100 merged 2 commits intoSep 27, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
WillSewell
reviewed
Aug 29, 2018
Comment thread
src/main/java/com/pusher/client/connection/websocket/WebSocketConnection.java
Outdated
| // Received error codes 4000 >= 4099 indicate we shouldn't attempt reconnection | ||
| // https://pusher.com/docs/pusher_protocol#error-codes | ||
| private boolean shouldReconnect(int code) { | ||
| return !(code >= 4000 && code <= 4099); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I'd personally find this easier to read without the negative, i.e. code < 4000 || code >= 4100, but it's not a big deal.
Sorry, something went wrong.
Comment thread
src/main/java/com/pusher/client/connection/websocket/WebSocketConnection.java
Outdated
| }, reconnectInterval, TimeUnit.SECONDS); | ||
| } | ||
|
|
||
| // Received error codes 4000 >= 4099 indicate we shouldn't attempt reconnection |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I'm not clear what 4000 >= 4099 precisely means. What about the notation the docs use 4000-4099?
Sorry, something went wrong.
WillSewell
approved these changes
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the pull request
Currently, the library ignores Pusher codes and therefore attempts reconnections. I have a feeling this will cause issues with future feature work we may do, so here's a fix.
Why is the change necessary?
Respecting protocol.
CC @pusher/mobile