FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: update changelog by henryiii · Pull Request #3099 · pybind/pybind11 · GitHub

/ pybind11 Public

docs: update changelog - #3099

Merged
henryiii merged 2 commits into
pybind:masterfrom
henryiii:henryiii/docs/changelog
Jul 13, 2021
ConversationCommits (2)ChecksFiles changed
Merged

docs: update changelog#3099
henryiii merged 2 commits into
pybind:masterfrom
henryiii:henryiii/docs/changelog

Conversation

henryiii commented Jul 12, 2021

Copy link
Copy Markdown
Collaborator

Description

Updates the changelog with the marked PRs.

rwgk commented Jul 12, 2021

Copy link
Copy Markdown
Collaborator

The flake is #2995 again.
I think it's very important to merge #2995 before the 2.7 release.

henryiii commented Jul 12, 2021

Copy link
Copy Markdown
Collaborator Author

But on PyPy macOS this time?

rwgk reviewed Jul 12, 2021
View reviewed changes

rwgk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks great, my main concern is that #2995 isn't included.

I think we need to be completely open about the undefined behavior, to not mislead users. I'm also thinking that we are more likely to attract a volunteer to develop a fix if we're open about the issue.

To add my own experience, it is no exaggeration that I scrolled through failed jobs 100+ times to be sure it's that flake, and it's an error each time I run TSAN.

I'd be happy quickly address suggestions on #2995.

Comment thread docs/changelog.rst Outdated

henryiii commented Jul 12, 2021

Copy link
Copy Markdown
Collaborator Author

This is not the final changelog before 2.7 (though I expect we are getting close), just an update to the current changelog that has been long delayed.

henryiii force-pushed the henryiii/docs/changelog branch from 510c76d to a808c17 Compare July 12, 2021 20:59
henryiii merged commit 6a644c8 into pybind:master Jul 13, 2021
henryiii deleted the henryiii/docs/changelog branch July 13, 2021 04:08
rwgk mentioned this pull request Feb 10, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rwgk rwgk left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL