Repository navigation
Monokai: fix contrast ratios to meet WCAG AA guidelines - #2448
Merged
jeanas merged 2 commits intoJun 7, 2023
Merged
jeanas merged 2 commits into
jeanas merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM, thank you. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using Monokai the new dark theme for for CPython docs: python/python-docs-theme#44 - for example: https://docs.python.org/3.12/
Using the same technique as #2325 and #2038, here's contrast improvements to meet the WCAG AA guidelines.
For example, here we can see Keyword.Namespace (>>> import) and Comment (# Return the current working directory) (from https://docs.python.org/3.12/tutorial/stdlib.html):
This also increased the minimum contrast of Monokai from 2.3 to 4.6, so tests/contrast/min_contrasts.json was updated, and I also ran scripts/update_contrasts.py as requested by tests and it sorted, and added some other missing styles.