Add specification for compiling logbook - #1920
Merged
hoodmane merged 6 commits intoNov 4, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Currently the CI run test-core-chrome is failing with some kind of time-out. I suspect this is not caused by changes in this PR though. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Indeed, selenium tests are just flaky. We probably should put a warning about this somewhere that people opening PRs will read. Everyone has the same issue on their first PR of trying to determine which failures are diagnostic and which are just noise. Well to be fair, this is an ongoing difficulty for everyone not just new contributors. |
Sorry, something went wrong.
hoodmane
approved these changes
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a project I'm attempting with pyodide I need a pure Python package that has logbook as a dependency, hence this compilation specification.