Support TLS connection in node socket - #6166
Merged
ryanking13 merged 24 commits intoApr 29, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
hoodmane
reviewed
Apr 21, 2026
Comment thread
src/js/fs/nodesockfs.ts
Outdated
hoodmane
reviewed
Apr 21, 2026
Comment thread
src/py/ssl.py
hoodmane
reviewed
Apr 21, 2026
Comment thread
src/py/ssl.py
Outdated
hoodmane
reviewed
Apr 21, 2026
Comment thread
src/tests/test_python_socket.py
Outdated
hoodmane
reviewed
Apr 21, 2026
Comment thread
src/tests/test_python_socket.py
Outdated
hoodmane
reviewed
Apr 21, 2026
Comment thread
src/py/ssl.py
Outdated
hoodmane
reviewed
Apr 21, 2026
Comment thread
src/tests/test_database_driver.py
hoodmane
reviewed
Apr 21, 2026
Comment thread
src/tests/test_database_driver.py
hoodmane
approved these changes
Apr 21, 2026
hoodmane
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good to me aside from some nitpicks.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #6145.
This implements startTLS function under the node socket API, which upgrades the connection. It is used in create_connection function in the ssl library.