Repository navigation
Check newly added links in PRs - #2135
Open
navya-exe wants to merge 2 commits into
Open
navya-exe wants to merge 2 commits into
navya-exe wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
for more information, see https://pre-commit.ci
rgommers
requested changes
Nov 11, 2026
rgommers
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This follows the approach suggested in #2037, but it seems like a drive-by PR. At least three gaps need addressing:
- The escaped URLs need end anchors. As written, a known URL like https://example.org/docs also suppresses checks for newly added /docs/new-page or #missing-anchor URLs.
- The workflow retains continue-on-error for PRs and merge queues, so newly introduced broken links still won’t block merging.
- There’s no cache-miss fallback. If the exact-base cache is unavailable, the job silently checks every link again. It should generate the baseline on demand, or explicitly report that filtering could not be applied.
I implemented a much more comprehensive approach in gh-2182 that doesn't have these problems. I'm inclined to close this PR.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Requested changes must be addressed to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2037
This changes the linkcheck setup so that, during pull requests and merge queues, links that already existed in the base revision are ignored.
A cached linkcheck baseline from the base revision is restored before linkcheck runs, while the baseline is updated from the main branch.
This allows PR linkcheck to focus on newly added links.
Local validation:
📚 Documentation preview 📚: https://python-packaging-user-guide--2135.org.readthedocs.build/en/2135/