FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Organize index of guides into 3 categories by pastelmind · Pull Request #708 · pypa/packaging.python.org · GitHub

/ packaging.python.org Public

Organize index of guides into 3 categories - #708

Merged
di merged 3 commits into
pypa:masterfrom
pastelmind:organize-guides-index
Dec 11, 2020
ConversationCommits (3)ChecksFiles changed
Merged

Organize index of guides into 3 categories#708
di merged 3 commits into
pypa:masterfrom
pastelmind:organize-guides-index

Conversation

pastelmind commented Mar 13, 2020

Copy link
Copy Markdown
Contributor

Split the toctree of guides into three broad categories:

  • Installing Packages
    • Includes guides for installing and managing dependencies.
  • Building and Publishing Projects
    • Includes guides for project configuration, distribution
  • Miscellaneous
    • Guides that do not clearly fit into any of the above

This commit primarily affects the Guides index page; it does not create nested lists for each category in the sidebar.

Organize index of guides into 3 categories
d8c125b 
Split the toctree of guides into three broad categories:

- Installing Packages
    - Includes guides for installing and managing dependencies.
- Building and Publishing Projects
    - Includes guides for project configuration, distribution
- Miscellaneous
    - Guides that do not clearly fit into any of the above

This commit primarily affects the Guides index page; it does not create
nested lists for each category in the sidebar.
pastelmind mentioned this pull request Mar 13, 2020
Closed
webknjaz requested a review from a team December 10, 2020 15:39
di reviewed Dec 10, 2020
View reviewed changes
Comment thread source/guides/index.rst Outdated
Comment on lines +42 to +43
index-mirrors-and-caches
hosting-your-own-index

di Dec 10, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think these two should be under "installing".

pastelmind Dec 11, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good point. If I update the PR, do I have to wait another 9 months to get another review?

pradyunsg Dec 11, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No.

pastelmind commented Dec 11, 2020

Copy link
Copy Markdown
Contributor Author

@di Moved the two items. I'm sorry about making a snarky comment earlier.

pradyunsg commented Dec 11, 2020

Copy link
Copy Markdown
Member

Comparing the sidebar between https://packaging.python.org/ and https://python-packaging-user-guide--708.org.readthedocs.build/, I'd prefer to keep the sidebar unchanged.

Is there some change that I'm missing?

di commented Dec 11, 2020

Copy link
Copy Markdown
Member

@pradyunsg Looks like that was due to the branch being out of date.

di merged commit 9ef40af into pypa:master Dec 11, 2020

di commented Dec 11, 2020

Copy link
Copy Markdown
Member

Thanks @pastelmind!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

di di left review comments
pradyunsg pradyunsg left review comments
webknjaz webknjaz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL