FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

WIP: Add sdist format specification and metadata field (PEP 643) by pfmoore · Pull Request #785 · pypa/packaging.python.org · GitHub

/ packaging.python.org Public

WIP: Add sdist format specification and metadata field (PEP 643) - #785

Merged
pfmoore merged 7 commits into
pypa:masterfrom
pfmoore:pep643
Jan 1, 2021
ConversationCommits (7)ChecksFiles changed
Merged

WIP: Add sdist format specification and metadata field (PEP 643)#785
pfmoore merged 7 commits into
pypa:masterfrom
pfmoore:pep643

Conversation

pfmoore commented Oct 31, 2020

Copy link
Copy Markdown
Member

No description provided.

webknjaz reviewed Nov 1, 2020
View reviewed changes
Comment thread source/specifications/core-metadata.rst
Core metadata specifications
============================

The current core metadata file format, version 2.1, is specified in :pep:`566`.

webknjaz Nov 1, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Old PEP removed but no mention of a new PEP 643? Is this intentional?

pfmoore Nov 1, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, because PEP 643 does not specify the whole format, just the addition. I didn't think it made sense to say "Version 2.1 was specified in 566, which also made this document canonical, then 643 updated it to 2.2" with the result that the paragraph becomes an extended audit trail of all the PEPs that change the spec.

IMO, the whole point of making this document canonical is that we don't need to link back to the PEPs. 2.1 linking back to 566 was OK, as that was the version that changed the canonical source of the spec. But now we've moved to the next version, I think it's time to drop the (essentially historical, now) note.

pfmoore and others added 3 commits November 1, 2020 20:51
Apply suggestions from code review
5da5bc6 
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Various updates for PEP 643
886bb62 
1. Remove the whitelist of fields allowed to be dynamic.
2. Allow Dynamic outside of source distributions.
Merge branch 'pep643' of https://github.com/pfmoore/python-packaging-…
7cc7fac 
…user-guide into pep643

eduardsmith commented Nov 14, 2020

Copy link
Copy Markdown

Nice

sbidoul approved these changes Jan 1, 2021
View reviewed changes

sbidoul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@pfmoore was this ready to be merged ?

pfmoore commented Jan 1, 2021

Copy link
Copy Markdown
Member Author

@sbidoul Drat, yes. Thanks for the reminder, I don't know how I forgot this 🙁

pfmoore merged commit ae48f92 into pypa:master Jan 1, 2021
bhrutledge mentioned this pull request May 17, 2021
Closed
bgilbert mentioned this pull request Nov 30, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

webknjaz webknjaz left review comments
xavfernandez xavfernandez left review comments
+1 more reviewer
sbidoul sbidoul approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL