Honor declared ordering for Provides-Extra entries in package metadata. by jaraco · Pull Request #1690 · pypa/setuptools · GitHub

Alternative approach to #1305, this approach simply replaces the set with an ordered set, retaining the order of extras as found in the package's 'extras_require' dictionary. On older Pythons where the dictionary ordering is non-deterministic, that non-determinism will still be present.

Summary of changes

Closes

Pull Request Checklist

Changes have tests
News fragment added in changelog.d. See documentation for details

@jaraco Haven't looked into it too much, do we need to bring in OrderedSet? Are there set operations later on that are used on it? I'm assuming the set is being used because the requirements are supposed to be unique. If it doesn't have to be a set, maybe we can get away with the unique subset of the list?

def unique_list(it):
    unique = set()
    out = []
    for item in it:
        if item not in unique:
            unique.add(item)
            out.append(item)
    return out

Ah, it does use add, I guess OrderedSet is fine for this.

I agree. Adding a dependency for this change is probably overkill. Especially if it only doesn’t address the root issue - that before Python 3.6, extras are going to be defined in a non-deterministic order. So maybe it makes sense to order them and remove duplicates explicitly.

@stevenengler Given the goal of having reproducible builds, would it be sufficient to solve that only on Python 3.6+ plus Python 2.7 (without PYTHONHASHSEED set)? If the solution could restrict to those environments, an approach similar to this one would be possible without enforcing a order (deferring to the order indicated by the package).

I'm guessing builders will want reproducible builds on all supported Python versions, but it would be simpler and less intrusive not to do so, and sets forth a pattern for giving packagers more control over the ordering of fields in the metadata.

would it be sufficient to solve that only on Python 3.6+ plus Python 2.7

Let's assume yes.

Hi, what is the status of this pull request?

would it be sufficient to solve that only on Python 3.6+ plus Python 2.7

Let's assume yes.

This is definitely sufficient for Arch Linux, as only the latest 3.x and 2.x versions are used for Python packages. Not sure about other major distros like Debian or Fedora, though.

Hi, what is the status of this pull request?

I've had a shortcut on my desktop nagging me to deal with this since I last commented on it. I just hadn't gotten around to it. I have now and have merged the changes.

Shouldn't this be pinned to the particular version vendored-in?

Perhaps. I realized that the vendored dependencies are implicitly pinned when paver update_vendored is run... so I'm okay with leaving this declaration unpinned. But you're right to be concerned - why the inconsistency? Just because I'd rather remove the pins... but those other dependencies have probably advanced since they were last updated. My desire is to unpin the others and run another update operation.

I do think it would be valuable if the dependency isn't declared as a pinned one to capture the effectively pinned version during the update operation.

On the other hand, pinning the dependencies make it easier to know which version of each package is vendored and to update only some of those dependencies.

I've done that for now in 734d09c.

FYI: This can cause problems if you try to use setuptools with multiprocessing, since it makes metadata not pickle cleanly.

Traceback (most recent call last):
  File "/Users/dan/Documents/colcon_ws/src/colcon-python-setup-py/colcon_python_setup_py/package_identification/python_setup_py.py", line 257, in get_setup_information
    'stop_after': 'config'
  File "/usr/local/Cellar/python/3.7.4_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/multiprocessing/pool.py", line 261, in apply
    return self.apply_async(func, args, kwds).get()
  File "/usr/local/Cellar/python/3.7.4_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/multiprocessing/pool.py", line 657, in get
    raise self._value
multiprocessing.pool.MaybeEncodingError: Error sending result: '<distutils.dist.DistributionMetadata object at 0x10c1fcd50>'. Reason: 'PicklingError("Can't pickle <class 'setuptools._vendor.ordered_set.OrderedSet'>: it's not the same object as setuptools._vendor.ordered_set.OrderedSet")'

[1] pypa/setuptools#1690

Manually re-applied: 008-distutils-use-python-sysroot.patch 016-adjust-config-paths.patch Add patch '026-openssl-feature-flags.patch' We need to keep this in our tree for a while. See: https://bugs.python.org/issue43669 Drop patch: 003-do-not-run-distutils-tests.patch There is now a configure option '--disable-test-modules' Refs: https://bugs.python.org/issue27640 https://bugs.python.org/issue43282 Drop patch: 013-getbuildinfo-date-time-source-date-epoch.patch Converted to Makefile rules. This could have been done earlier, but the inspiration did not hit until now. Drop setuptools patches. Setuptools should be reproducible with Python 3.6+ according to a mention here: pypa/setuptools#1690 (comment) It's time to let upstream fix Setuptools reproduce-ability. Refreshed the rest of patches. For the host Python we also need to define the OPENSSL_THREADS macro. OpenSSL in tools/openssl doesn't build with threads support, but CPython's _ssl module really wants this define (as there's an #error directive). Also, enabling threads in tools/openssl opens a whole new set of problems. So, we need to fake it here or patch it out of the _ssl module. Technically, CPython works fine without OpenSSL threads, but upstream wants to keep their test-matrix limited. And we need _ssl for accessing pypi.org to download packages. And host CPython usage is limited to build, so we should (hopefully) be fine with this. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Manually re-applied: 008-distutils-use-python-sysroot.patch 016-adjust-config-paths.patch Add patch '026-openssl-feature-flags.patch' We need to keep this in our tree for a while. See: https://bugs.python.org/issue43669 Drop patch: 003-do-not-run-distutils-tests.patch There is now a configure option '--disable-test-modules' And seems we left the '_ctypes_test' around for quite some time. Dropped now. Refs: https://bugs.python.org/issue27640 https://bugs.python.org/issue43282 Drop patch: 013-getbuildinfo-date-time-source-date-epoch.patch Python build honors SOURCE_DATE_EPOCH pretty well now. Drop setuptools patches. Setuptools should be reproducible with Python 3.6+ according to a mention here: pypa/setuptools#1690 (comment) It's time to let upstream fix Setuptools reproduce-ability. Refreshed the rest of patches. For the host Python we also need to define the OPENSSL_THREADS macro. OpenSSL in tools/openssl doesn't build with threads support, but CPython's _ssl module really wants this define (as there's an #error directive). Also, enabling threads in tools/openssl opens a whole new set of problems. So, we need to fake it here or patch it out of the _ssl module. Technically, CPython works fine without OpenSSL threads, but upstream wants to keep their test-matrix limited. And we need _ssl for accessing pypi.org to download packages. And host CPython usage is limited to build, so we should (hopefully) be fine with this. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Manually re-applied: 008-distutils-use-python-sysroot.patch 016-adjust-config-paths.patch Add patch '026-openssl-feature-flags.patch' We need to keep this in our tree for a while. See: https://bugs.python.org/issue43669 Drop patch: 003-do-not-run-distutils-tests.patch There is now a configure option '--disable-test-modules' And seems we left the '_ctypes_test' around for quite some time. Dropped now. Refs: https://bugs.python.org/issue27640 https://bugs.python.org/issue43282 Drop patch: 013-getbuildinfo-date-time-source-date-epoch.patch Python build honors SOURCE_DATE_EPOCH pretty well now. Drop setuptools patches. Setuptools should be reproducible with Python 3.6+ according to a mention here: pypa/setuptools#1690 (comment) It's time to let upstream fix Setuptools reproduce-ability. Drop patch: 010-do-not-add-rt-lib-dirs-when-cross-compiling.patch I can't seem to fully remember why it's there. And it seem to build fine without it. Refreshed the rest of patches. Split python3-uuid from python3-light. To better manage the libuuid library (if needed). Also, fixing the uuid C module build. Seems this was failing, and was falling back to using hashlib. For the host Python we also need to define the OPENSSL_THREADS macro. OpenSSL in tools/openssl doesn't build with threads support, but CPython's _ssl module really wants this define (as there's an #error directive). Also, enabling threads in tools/openssl opens a whole new set of problems. So, we need to fake it here or patch it out of the _ssl module. Technically, CPython works fine without OpenSSL threads, but upstream wants to keep their test-matrix limited. And we need _ssl for accessing pypi.org to download packages. And host CPython usage is limited to build, so we should (hopefully) be fine with this. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Manually re-applied: 008-distutils-use-python-sysroot.patch 016-adjust-config-paths.patch Add patch '026-openssl-feature-flags.patch' We need to keep this in our tree for a while. See: https://bugs.python.org/issue43669 Drop patch: 003-do-not-run-distutils-tests.patch There is now a configure option '--disable-test-modules' And seems we left the '_ctypes_test' around for quite some time. Dropped now. Refs: https://bugs.python.org/issue27640 https://bugs.python.org/issue43282 Drop patch: 013-getbuildinfo-date-time-source-date-epoch.patch Python build honors SOURCE_DATE_EPOCH pretty well now. Drop setuptools patches. Setuptools should be reproducible with Python 3.6+ according to a mention here: pypa/setuptools#1690 (comment) It's time to let upstream fix Setuptools reproduce-ability. Drop patch: 010-do-not-add-rt-lib-dirs-when-cross-compiling.patch I can't seem to fully remember why it's there. And it seem to build fine without it. Backport patch: 027-bpo-43158-Use-configure-values-for-building-_uuid-ex.patch Link: python/cpython#29353 Fixes the build for uuid C module. Refreshed the rest of patches. Split python3-uuid from python3-light. To better manage the libuuid library (if needed). Also, fixing the uuid C module build. Seems this was failing, and was falling back to using hashlib. For the host Python we also need to define the OPENSSL_THREADS macro. OpenSSL in tools/openssl doesn't build with threads support, but CPython's _ssl module really wants this define (as there's an #error directive). Also, enabling threads in tools/openssl opens a whole new set of problems. So, we need to fake it here or patch it out of the _ssl module. Technically, CPython works fine without OpenSSL threads, but upstream wants to keep their test-matrix limited. And we need _ssl for accessing pypi.org to download packages. And host CPython usage is limited to build, so we should (hopefully) be fine with this. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Manually re-applied: 008-distutils-use-python-sysroot.patch 016-adjust-config-paths.patch Add patch '026-openssl-feature-flags.patch' We need to keep this in our tree for a while. See: https://bugs.python.org/issue43669 Drop patch: 003-do-not-run-distutils-tests.patch There is now a configure option '--disable-test-modules' And seems we left the '_ctypes_test' around for quite some time. Dropped now. Refs: https://bugs.python.org/issue27640 https://bugs.python.org/issue43282 Drop patch: 013-getbuildinfo-date-time-source-date-epoch.patch Python build honors SOURCE_DATE_EPOCH pretty well now. Drop setuptools patches. Setuptools should be reproducible with Python 3.6+ according to a mention here: pypa/setuptools#1690 (comment) It's time to let upstream fix Setuptools reproduce-ability. Drop patch: 010-do-not-add-rt-lib-dirs-when-cross-compiling.patch I can't seem to fully remember why it's there. And it seem to build fine without it. Drop patch: 015-abort-on-failed-modules.patch Python build supports a similar PYTHONSTRICTEXTENSIONBUILD=1 env-var option. Backport patch: 027-bpo-43158-Use-configure-values-for-building-_uuid-ex.patch Link: python/cpython#29353 Fixes the build for uuid C module. Refreshed the rest of patches. Split python3-uuid from python3-light. To better manage the libuuid library (if needed). Also, fixing the uuid C module build. Seems this was failing, and was falling back to using hashlib. For the host Python we also need to define the OPENSSL_THREADS macro. OpenSSL in tools/openssl doesn't build with threads support, but CPython's _ssl module really wants this define (as there's an #error directive). Also, enabling threads in tools/openssl opens a whole new set of problems. So, we need to fake it here or patch it out of the _ssl module. Technically, CPython works fine without OpenSSL threads, but upstream wants to keep their test-matrix limited. And we need _ssl for accessing pypi.org to download packages. And host CPython usage is limited to build, so we should (hopefully) be fine with this. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Manually re-applied: 008-distutils-use-python-sysroot.patch 016-adjust-config-paths.patch Add patch '026-openssl-feature-flags.patch' We need to keep this in our tree for a while. See: https://bugs.python.org/issue43669 Drop patch: 003-do-not-run-distutils-tests.patch There is now a configure option '--disable-test-modules' And seems we left the '_ctypes_test' around for quite some time. Dropped now. Refs: https://bugs.python.org/issue27640 https://bugs.python.org/issue43282 Drop patch: 013-getbuildinfo-date-time-source-date-epoch.patch Python build honors SOURCE_DATE_EPOCH pretty well now. Drop setuptools patches. Setuptools should be reproducible with Python 3.6+ according to a mention here: pypa/setuptools#1690 (comment) It's time to let upstream fix Setuptools reproduce-ability. Drop patch: 010-do-not-add-rt-lib-dirs-when-cross-compiling.patch I can't seem to fully remember why it's there. And it seem to build fine without it. Drop patch: 015-abort-on-failed-modules.patch Python build supports a similar PYTHONSTRICTEXTENSIONBUILD=1 env-var option. Add patch: 026-openssl-feature-flags.patch We need to keep this in our tree for a while. See: https://bugs.python.org/issue45627 Backport patch: 027-bpo-43158-Use-configure-values-for-building-_uuid-ex.patch Link: python/cpython#29353 Fixes the build for uuid C module. Add hack-patch: 028-host-python-support-ssl-with-libressl.patch This is enabled only on the host Python3 interpreter via a OPENWRT_HOST_BUILD define. Python 3.10 prefers OpenSSL 1.1.1. OpenWrt uses LibreSSL in tools/libressl. It requires a bit of hacking to get it to work, so that Python can download packages from pypi.org. Refreshed the rest of patches. Some old build-flags were removed. They don't seem to be necessary anymore. Split python3-uuid from python3-light. To better manage the libuuid library (if needed). Also, fixing the uuid C module build. Seems this was failing, and was falling back to using hashlib. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Manually re-applied: 008-distutils-use-python-sysroot.patch 016-adjust-config-paths.patch Add patch '026-openssl-feature-flags.patch' We need to keep this in our tree for a while. See: https://bugs.python.org/issue43669 Drop patch: 003-do-not-run-distutils-tests.patch There is now a configure option '--disable-test-modules' And seems we left the '_ctypes_test' around for quite some time. Dropped now. Refs: https://bugs.python.org/issue27640 https://bugs.python.org/issue43282 Drop patch: 013-getbuildinfo-date-time-source-date-epoch.patch Python build honors SOURCE_DATE_EPOCH pretty well now. Drop setuptools patches. Setuptools should be reproducible with Python 3.6+ according to a mention here: pypa/setuptools#1690 (comment) It's time to let upstream fix Setuptools reproduce-ability. Drop patch: 010-do-not-add-rt-lib-dirs-when-cross-compiling.patch I can't seem to fully remember why it's there. And it seem to build fine without it. Drop patch: 015-abort-on-failed-modules.patch Python build supports a similar PYTHONSTRICTEXTENSIONBUILD=1 env-var option. Add patch: 026-openssl-feature-flags.patch We need to keep this in our tree for a while. See: https://bugs.python.org/issue45627 Backport patch: 027-bpo-43158-Use-configure-values-for-building-_uuid-ex.patch Link: python/cpython#29353 Fixes the build for uuid C module. Backport patch: 028-openbsd-ssl-patch-modules-ssl.patch From OpenBSD: https://raw.githubusercontent.com/openbsd/ports/9bd152efe0b635016c29b6d688de283c04c84058/lang/python/3.10/patches/patch-Modules__ssl_c We need the _ssl module working on the host-side for pip to work to download from https://pypi.org Refreshed the rest of patches. Some old build-flags were removed. They don't seem to be necessary anymore. Split python3-uuid from python3-light. To better manage the libuuid library (if needed). Also, fixing the uuid C module build. Seems this was failing, and was falling back to using hashlib. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Manually re-applied: 008-distutils-use-python-sysroot.patch 016-adjust-config-paths.patch Add patch '026-openssl-feature-flags.patch' We need to keep this in our tree for a while. See: https://bugs.python.org/issue43669 Drop patch: 003-do-not-run-distutils-tests.patch There is now a configure option '--disable-test-modules' And seems we left the '_ctypes_test' around for quite some time. Dropped now. Refs: https://bugs.python.org/issue27640 https://bugs.python.org/issue43282 Drop patch: 013-getbuildinfo-date-time-source-date-epoch.patch Python build honors SOURCE_DATE_EPOCH pretty well now. Drop setuptools patches. Setuptools should be reproducible with Python 3.6+ according to a mention here: pypa/setuptools#1690 (comment) It's time to let upstream fix Setuptools reproduce-ability. Drop patch: 010-do-not-add-rt-lib-dirs-when-cross-compiling.patch I can't seem to fully remember why it's there. And it seem to build fine without it. Drop patch: 015-abort-on-failed-modules.patch Python build supports a similar PYTHONSTRICTEXTENSIONBUILD=1 env-var option. Add patch: 026-openssl-feature-flags.patch We need to keep this in our tree for a while. See: https://bugs.python.org/issue45627 Backport patch: 027-bpo-43158-Use-configure-values-for-building-_uuid-ex.patch Link: python/cpython#29353 Fixes the build for uuid C module. Add patch: 028-host-python-support-ssl-with-libressl.patch We need the _ssl module working on the host-side for pip to work to download from https://pypi.org Refreshed the rest of patches. Some old build-flags were removed. They don't seem to be necessary anymore. Split python3-uuid from python3-light. To better manage the libuuid library (if needed). Also, fixing the uuid C module build. Seems this was failing, and was falling back to using hashlib. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Manually re-applied: 008-distutils-use-python-sysroot.patch 016-adjust-config-paths.patch Drop patch: 003-do-not-run-distutils-tests.patch There is now a configure option '--disable-test-modules' And seems we left the '_ctypes_test' around for quite some time. Dropped now. Refs: https://bugs.python.org/issue27640 https://bugs.python.org/issue43282 Drop patch: 013-getbuildinfo-date-time-source-date-epoch.patch Python build honors SOURCE_DATE_EPOCH pretty well now. Drop setuptools patches. Setuptools should be reproducible with Python 3.6+ according to a mention here: pypa/setuptools#1690 (comment) It's time to let upstream fix Setuptools reproduce-ability. Drop patch: 010-do-not-add-rt-lib-dirs-when-cross-compiling.patch I can't seem to fully remember why it's there. And it seem to build fine without it. Drop patch: 015-abort-on-failed-modules.patch Python build supports a similar PYTHONSTRICTEXTENSIONBUILD=1 env-var option. Add patch: 026-openssl-feature-flags.patch We need to keep this in our tree for a while. See: https://bugs.python.org/issue45627 Backport patch: 027-bpo-43158-Use-configure-values-for-building-_uuid-ex.patch Link: python/cpython#29353 Fixes the build for uuid C module. Add patch: 028-host-python-support-ssl-with-libressl.patch We need the _ssl module working on the host-side with LibreSSL for pip to work to download from https://pypi.org Refs: openwrt/openwrt#4749 Refreshed the rest of patches. Some old build-flags were removed. They don't seem to be necessary anymore. Split python3-uuid from python3-light. To better manage the libuuid library (if needed). Also, fixing the uuid C module build. Seems this was failing, and was falling back to using hashlib. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Manually re-applied: 008-distutils-use-python-sysroot.patch 016-adjust-config-paths.patch Drop patch: 003-do-not-run-distutils-tests.patch There is now a configure option '--disable-test-modules' And seems we left the '_ctypes_test' around for quite some time. Dropped now. Refs: https://bugs.python.org/issue27640 https://bugs.python.org/issue43282 Drop patch: 013-getbuildinfo-date-time-source-date-epoch.patch Python build honors SOURCE_DATE_EPOCH pretty well now. Drop setuptools patches. Setuptools should be reproducible with Python 3.6+ according to a mention here: pypa/setuptools#1690 (comment) It's time to let upstream fix Setuptools reproduce-ability. Drop patch: 010-do-not-add-rt-lib-dirs-when-cross-compiling.patch I can't seem to fully remember why it's there. And it seem to build fine without it. Drop patch: 015-abort-on-failed-modules.patch Python build supports a similar PYTHONSTRICTEXTENSIONBUILD=1 env-var option. Add patch: 026-openssl-feature-flags.patch We need to keep this in our tree for a while. See: https://bugs.python.org/issue45627 Backport patch: 027-bpo-43158-Use-configure-values-for-building-_uuid-ex.patch Link: python/cpython#29353 Fixes the build for uuid C module. Add patch: 028-host-python-support-ssl-with-libressl.patch We need the _ssl module working on the host-side with LibreSSL for pip to work to download from https://pypi.org Refs: openwrt/openwrt#4749 Add patch: 029-disable-deprecation-warning.patch Fixes apparmor build. The warning causes a configure error. Refreshed the rest of patches. Some old build-flags were removed. They don't seem to be necessary anymore. Split python3-uuid from python3-light. To better manage the libuuid library (if needed). Also, fixing the uuid C module build. Seems this was failing, and was falling back to using hashlib. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Manually re-applied: 008-distutils-use-python-sysroot.patch 016-adjust-config-paths.patch Drop patch: 003-do-not-run-distutils-tests.patch There is now a configure option '--disable-test-modules' And seems we left the '_ctypes_test' around for quite some time. Dropped now. Refs: https://bugs.python.org/issue27640 https://bugs.python.org/issue43282 Drop patch: 013-getbuildinfo-date-time-source-date-epoch.patch Python build honors SOURCE_DATE_EPOCH pretty well now. Drop setuptools patches. Setuptools should be reproducible with Python 3.6+ according to a mention here: pypa/setuptools#1690 (comment) It's time to let upstream fix Setuptools reproduce-ability. Drop patch: 010-do-not-add-rt-lib-dirs-when-cross-compiling.patch I can't seem to fully remember why it's there. And it seem to build fine without it. Drop patch: 015-abort-on-failed-modules.patch Python build supports a similar PYTHONSTRICTEXTENSIONBUILD=1 env-var option. Add patch: 026-openssl-feature-flags.patch We need to keep this in our tree for a while. See: https://bugs.python.org/issue45627 Backport patch: 027-bpo-43158-Use-configure-values-for-building-_uuid-ex.patch Link: python/cpython#29353 Fixes the build for uuid C module. Add patch: 028-host-python-support-ssl-with-libressl.patch We need the _ssl module working on the host-side with LibreSSL for pip to work to download from https://pypi.org Refs: openwrt/openwrt#4749 Refreshed the rest of patches. Some old build-flags were removed. They don't seem to be necessary anymore. Split python3-uuid from python3-light. To better manage the libuuid library (if needed). Also, fixing the uuid C module build. Seems this was failing, and was falling back to using hashlib. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Manually re-applied: 008-distutils-use-python-sysroot.patch 016-adjust-config-paths.patch Drop patch: 003-do-not-run-distutils-tests.patch There is now a configure option '--disable-test-modules' And seems we left the '_ctypes_test' around for quite some time. Dropped now. Refs: https://bugs.python.org/issue27640 https://bugs.python.org/issue43282 Drop patch: 013-getbuildinfo-date-time-source-date-epoch.patch Python build honors SOURCE_DATE_EPOCH pretty well now. Drop setuptools patches. Setuptools should be reproducible with Python 3.6+ according to a mention here: pypa/setuptools#1690 (comment) It's time to let upstream fix Setuptools reproduce-ability. Drop patch: 010-do-not-add-rt-lib-dirs-when-cross-compiling.patch I can't seem to fully remember why it's there. And it seem to build fine without it. Drop patch: 015-abort-on-failed-modules.patch Python build supports a similar PYTHONSTRICTEXTENSIONBUILD=1 env-var option. Add patch: 026-openssl-feature-flags.patch We need to keep this in our tree for a while. See: https://bugs.python.org/issue45627 Backport patch: 027-bpo-43158-Use-configure-values-for-building-_uuid-ex.patch Link: python/cpython#29353 Fixes the build for uuid C module. Add patch: 028-host-python-support-ssl-with-libressl.patch We need the _ssl module working on the host-side with LibreSSL for pip to work to download from https://pypi.org Refs: openwrt/openwrt#4749 Add patch: 029-disable-deprecation-warning.patch Fixes apparmor build. The warning causes a configure error. Refreshed the rest of patches. Some old build-flags were removed. They don't seem to be necessary anymore. Split python3-uuid from python3-light. To better manage the libuuid library (if needed). Also, fixing the uuid C module build. Seems this was failing, and was falling back to using hashlib. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com> Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>

Manually re-applied: 008-distutils-use-python-sysroot.patch 016-adjust-config-paths.patch Drop patch: 003-do-not-run-distutils-tests.patch There is now a configure option '--disable-test-modules' And seems we left the '_ctypes_test' around for quite some time. Dropped now. Refs: https://bugs.python.org/issue27640 https://bugs.python.org/issue43282 Drop patch: 013-getbuildinfo-date-time-source-date-epoch.patch Python build honors SOURCE_DATE_EPOCH pretty well now. Drop setuptools patches. Setuptools should be reproducible with Python 3.6+ according to a mention here: pypa/setuptools#1690 (comment) It's time to let upstream fix Setuptools reproduce-ability. Drop patch: 010-do-not-add-rt-lib-dirs-when-cross-compiling.patch I can't seem to fully remember why it's there. And it seem to build fine without it. Drop patch: 015-abort-on-failed-modules.patch Python build supports a similar PYTHONSTRICTEXTENSIONBUILD=1 env-var option. Add patch: 026-openssl-feature-flags.patch We need to keep this in our tree for a while. See: https://bugs.python.org/issue45627 Backport patch: 027-bpo-43158-Use-configure-values-for-building-_uuid-ex.patch Link: python/cpython#29353 Fixes the build for uuid C module. Add patch: 028-host-python-support-ssl-with-libressl.patch We need the _ssl module working on the host-side with LibreSSL for pip to work to download from https://pypi.org Refs: openwrt/openwrt#4749 Add patch: 029-disable-deprecation-warning.patch Fixes apparmor build. The warning causes a configure error. Refreshed the rest of patches. Some old build-flags were removed. They don't seem to be necessary anymore. Split python3-uuid from python3-light. To better manage the libuuid library (if needed). Also, fixing the uuid C module build. Seems this was failing, and was falling back to using hashlib. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>

jaraco added 3 commits February 17, 2019 17:08

Add test capturing expectation that provides_extras are ordered.

4a6b8ba

Add 'ordered_set' as a vendored package

3d289a7

Use an ordered set when constructing 'extras provided'. Ref #1305 .

636070d

jaraco mentioned this pull request Feb 17, 2019

[wip] Sorted PKG-INFO file fields to make it reproducible #1305

Closed

In tests, force deterministic ordering on extras_require so tests pass.

7f7780e

jaraco force-pushed the feature/deterministic-provides-extras branch from 94c5b66 to 7f7780e Compare February 17, 2019 22:37

jaraco changed the title Honor declared ordering for Provides-Extra entries in package metadata. WIP: Honor declared ordering for Provides-Extra entries in package metadata. Feb 17, 2019

jaraco force-pushed the feature/deterministic-provides-extras branch from d953a7d to 7f7780e Compare February 20, 2019 13:37

Merge branch 'master' into feature/deterministic-provides-extras

b3ef77b

jaraco changed the title WIP: Honor declared ordering for Provides-Extra entries in package metadata. Honor declared ordering for Provides-Extra entries in package metadata. Sep 11, 2019

Update changelog. Ref #1690 .

45b83cd

Refresh vendored packages (ordereddict 3.1.1)

6f962a0

jaraco merged commit 7a909b2 into master Oct 7, 2019

jaraco deleted the feature/deterministic-provides-extras branch October 7, 2019 01:24

benoit-pierre reviewed Oct 7, 2019

View reviewed changes

rotu mentioned this pull request Oct 25, 2019

package metadata is no longer picklable #1888

Closed

Foxboron added a commit to Foxboron/archlinux-pkgbuilds that referenced this pull request Dec 2, 2019

upgpkg: python-autobahn 19.11.1-2

9c84e6a

[1] pypa/setuptools#1690

commodo mentioned this pull request Nov 14, 2021

python3: bump to version 3.10.0 openwrt/packages#17121

Merged

               packaging==16.8
               pyparsing==2.2.1
               six==1.10.0
+              ordered-set

Honor declared ordering for Provides-Extra entries in package metadata. by jaraco · Pull Request #1690 · pypa/setuptools · GitHub

Repository navigation

Honor declared ordering for Provides-Extra entries in package metadata. - #1690

Honor declared ordering for Provides-Extra entries in package metadata.#1690jaraco merged 7 commits intomasterpypa/setuptools:masterfrom feature/deterministic-provides-extraspypa/setuptools:feature/deterministic-provides-extrasCopy head branch name to clipboard

Conversation

jaraco commented Feb 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Pull Request Checklist

Uh oh!

pganssle commented Feb 17, 2019

Uh oh!

pganssle commented Feb 17, 2019

Uh oh!

jaraco commented Feb 17, 2019

Uh oh!

jaraco commented Feb 18, 2019

Uh oh!

jaraco commented Sep 11, 2019

Uh oh!

yan12125 commented Sep 30, 2019

Uh oh!

jaraco commented Oct 7, 2019

Uh oh!

benoit-pierre Oct 7, 2019

Choose a reason for hiding this comment

Uh oh!

jaraco Oct 7, 2019

Choose a reason for hiding this comment

Uh oh!

jaraco Oct 7, 2019

Choose a reason for hiding this comment

Uh oh!

benoit-pierre Oct 7, 2019

Choose a reason for hiding this comment

Uh oh!

jaraco Oct 7, 2019

Choose a reason for hiding this comment

Uh oh!

rotu commented Oct 24, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Honor declared ordering for Provides-Extra entries in package metadata.#1690
jaraco merged 7 commits into
masterfrom
feature/deterministic-provides-extras

jaraco commented Feb 17, 2019 •
edited
Loading