| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
amend after discussing this with the team we decided to never throw errors because while Pyodide provides a list of packages built to target Pyodide itself, we don't get to know AOT (ahead of time) if a package might just work because it's a pure Python wheel directly fetched from pypi ... this MR simplifies a lot the warning dance + it optimizes the "graph" in a way that's lighter and easier to reason about (everything is just an in operation away via proxies). /cc @ntoll |
Sorry, something went wrong.
There was a problem hiding this comment.
![]()
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
The goal of this MR is to fix https://github.com/pyscript/polyscript/issues/161 however I think it's optimistic to believe Pyodide and its micropip related to that pyodide could do anything about packages not compatible/available for a specific Pyodide version.
The thing is, if I force version 0.28.0 which is not compatible with pygame-ce there's apparently no way to force loading a previous version of pygame-ce even if it used to be compatible.
This makes our discussion around pinned versions mostly irrelevant, although the logic to warn instead of always throwing is in place, I really would like to have a concrete example of when that warning should be read but the older package should still work (this is in particular for @mchilvers and @fpliger)
/cc @ntoll as it looks that we cannot control much of this dance, I might ping Hood around this topic too (he is not watching this space, it'll happen on discord).
for history sake I'll keep the previous idea, but now it's definitively easier for everyone
Current Previous State