FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Temporary fix to update_all (Immediate bug fix) by iliketocode2 · Pull Request #2455 · pyscript/pyscript · GitHub

/ pyscript Public

Temporary fix to update_all (Immediate bug fix) - #2455

Merged
WebReflection merged 5 commits into
pyscript:mainfrom
iliketocode2:fix-update_all
Feb 25, 2026
ConversationCommits (5)ChecksFiles changed
Merged

Temporary fix to update_all (Immediate bug fix)#2455
WebReflection merged 5 commits into
pyscript:mainfrom
iliketocode2:fix-update_all

Conversation

iliketocode2 commented Feb 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR refactors the update_all method in ElementCollection to use the update method exclusively. It is meant to be a temporary and immediate bug fix before a further (possible) refactor occurs.

See discussion #2453 for more details and the subsequent conversation.

Changes

  • Modified ElementCollection.update_all in core/src/stdlib/pyscript/web.py to explicitly accept classes and style arguments.
  • Replaced the manual setattr loop with a direct call to element.update(classes=classes, style=style, **kwargs)
  • Updated the docstring for update_all
  • New tests for update_all: test_update_all_classes_parameter, test_update_all_style_parameter, and test_update_all_combined.

Changes in pyscript/docs can be seen in this PR:

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

iliketocode2 mentioned this pull request Feb 25, 2026
Closed
WebReflection approved these changes Feb 25, 2026
View reviewed changes

WebReflection left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

great simplification, thank you!

WebReflection commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

@iliketocode2 do you have access rights to merge your own PRs after approval? If not, @ntoll , should we grant him that possibility?

iliketocode2 commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

I do not yet have permission to merge my own PR's after approval.

WebReflection merged commit e976967 into pyscript:main Feb 25, 2026
2 checks passed

ntoll commented Feb 26, 2026

Copy link
Copy Markdown
Member

Dammit - I look away for a moment and there you are, submitting PRs, having them reviewed and approved... and now also merged! 🤣

Bravo! 🚀

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

WebReflection WebReflection approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL