fixed GraphCRF._set_size_joint_feature - #196
Open
ShigekiKarita wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks. Can you please add a regression test? Currently tests are passing on Python3.4 |
Sorry, something went wrong.
mattfabina
referenced
this pull request
Apr 7, 2017
Copy link
Copy Markdown
Author
|
Hi. Is there any example or existing regression test? |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Just ran into this. Would it be possible to merge the fix without a regression test? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Hi, |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed GraphCRF._set_size_joint_feature
The problem is that size_joint_feature set a float value for its shape.
For the details, please read this log.
python plot_grid_crf.py [17:09:30] Traceback (most recent call last): File "plot_grid_crf.py", line 26, in <module> clf.fit(X, Y) File "/home/skarita/.pyenv/versions/pystruct/lib/python3.5/site-packages/pystruct-0.2.5-py3.5-linux-x86_64.egg/pystruct/learners/ one_slack_ssvm.py", line 409, in fit self.w = np.zeros(self.model.size_joint_feature) TypeError: 'float' object cannot be interpreted as an integer