FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Copy docstrings to wrapped pdb methods by adamchainz · Pull Request #12947 · pytest-dev/pytest · GitHub

/ pytest Public

Copy docstrings to wrapped pdb methods - #12947

Merged
nicoddemus merged 1 commit into
pytest-dev:mainfrom
adamchainz:pdb_docstrings
Mar 1, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Copy docstrings to wrapped pdb methods#12947
nicoddemus merged 1 commit into
pytest-dev:mainfrom
adamchainz:pdb_docstrings

Conversation

adamchainz commented Nov 8, 2024

Copy link
Copy Markdown
Member

Closes #12946.

psf-chronographer Bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Nov 8, 2024
nicoddemus approved these changes Nov 8, 2024
View reviewed changes

nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @adamchainz!

nicoddemus reviewed Nov 8, 2024
View reviewed changes
Comment thread changelog/12946.bugfix.rst Outdated

nicoddemus commented Nov 10, 2024

Copy link
Copy Markdown
Member

Hmm the tests are failing, can you take a look @adamchainz ?

webknjaz reviewed Nov 10, 2024
View reviewed changes
Comment thread src/_pytest/debugging.py
do_c = do_cont = do_continue

def do_quit(self, arg):
"""Raise Exit outcome when quit command is used in pdb.

webknjaz Nov 10, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why not keep this as is?

nicoddemus Nov 18, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems reasonable to copy the original docstring from do_quit, which is the purpose of the PR... turning into a comment makes sure we do not lose that information.

adamchainz Dec 27, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, I changed this because it won't be the real docstring at runtime after __doc__ is set.

Comment thread changelog/12946.bugfix.rst Outdated
adamchainz force-pushed the pdb_docstrings branch 2 times, most recently from ecc28fe to 6827227 Compare December 27, 2024 15:33
Copy docstrings to wrapped pdb methods
cc0b883 
Co-authored-by: Bruno Oliveira <bruno@pytest.org>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
nicoddemus merged commit 0646383 into pytest-dev:main Mar 1, 2025

nicoddemus commented Mar 1, 2025

Copy link
Copy Markdown
Member

Thanks @adamchainz!

adamchainz deleted the pdb_docstrings branch March 2, 2025 22:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

webknjaz webknjaz left review comments
nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pytest pdb commands missing documentation

3 participants

Back | FazBrowse Home | New Git URL