Prevent parametrize with scope from breaking fixture dependencies - #13249
Merged
RonnyPfannschmidt merged 4 commits intoMar 9, 2025
Merged
Prevent parametrize with scope from breaking fixture dependencies#13249RonnyPfannschmidt merged 4 commits into
RonnyPfannschmidt merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
testing/python/fixtures.py
Outdated
Anton3
marked this pull request as ready for review
February 24, 2025 12:26
RonnyPfannschmidt
approved these changes
Feb 25, 2025
Comment thread
src/_pytest/fixtures.py
nicoddemus
approved these changes
Mar 1, 2025
nicoddemus
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thanks @Anton3!
Leaving merging to @RonnyPfannschmidt as requested. 👍
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@RonnyPfannschmidt are you, per chance, ready to apply the fix in this PR for now? 👀 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
i still haven't gotten around to fully digest
but i think i should just merge this now as its kinda in line with the story they paint |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13248