Clean up type hints from #13345 and add a test - #13348
Merged
nicoddemus merged 2 commits intoApr 3, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
rouge8
marked this pull request as ready for review
April 3, 2025 18:46
The-Compiler
approved these changes
Apr 3, 2025
The-Compiler
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM other than the changelog thing, thanks for the follow-up!
Sorry, something went wrong.
Comment thread
changelog/13348.misc.rst
Outdated
nicoddemus
enabled auto-merge (squash)
April 3, 2025 19:45
Copy link
Copy Markdown
Member
|
Thanks folks! Took the liberty of removing the changelog entry. 👍 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thank you! I saw CI fail when I didn't have the changelog, so I thought I had to had one. Didn't realize you could use a label to skip it 😅 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on discussion in #13345.