testing: skip pkg_resources tests if modern setuptools - #13444
Merged
bluetech merged 1 commit intoMay 28, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
setuptools is intending to remove `pkg_resources` at the end of the year. Version 80.9.0 changed the deprecation to a UserMessage which broke the test. Instead of making them compatible, just skip them on versions >= 80 in preparation for the final removal.
RonnyPfannschmidt
approved these changes
May 27, 2025
Copy link
Copy Markdown
Backport to 8.3.x: 💚 backport PR created✅ Backport PR branch: patchback/backports/8.3.x/c7aabccde27f668eca901efa24539c170eb8ab42/pr-13444 Backported as #13446 🤖 @patchback |
Sorry, something went wrong.
patchback Bot
pushed a commit
that referenced
this pull request
May 28, 2025
testing: skip `pkg_resources` tests if modern setuptools (cherry picked from commit c7aabcc)
bluetech
added a commit
that referenced
this pull request
May 28, 2025
…7aabccde27f668eca901efa24539c170eb8ab42/pr-13444 [PR #13444/c7aabccd backport][8.3.x] testing: skip `pkg_resources` tests if modern setuptools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptools is intending to remove pkg_resources at the end of the year. Version 80.9.0 changed the deprecation to a UserMessage which broke the test. Instead of making them compatible, just skip them on versions >= 80 in preparation for the final removal.
Following Ronny's suggestion.