Fix decimal.FloatOperation error in pytest.approx Decimal __repr__ - #13543
Merged
nicoddemus merged 7 commits intoJun 22, 2025
Merged
Fix decimal.FloatOperation error in pytest.approx Decimal __repr__ #13543nicoddemus merged 7 commits into
nicoddemus merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
nicoddemus
approved these changes
Jun 18, 2025
nicoddemus
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thanks!
Sorry, something went wrong.
Comment thread
testing/python/approx.py
Outdated
nicoddemus
reviewed
Jun 18, 2025
Comment thread
testing/python/approx.py
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Hi @nicoddemus please have a look on the PR once. Thank you |
Sorry, something went wrong.
for more information, see https://pre-commit.ci
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
nicoddemus
force-pushed
the
fix/decimal-approx-repr-code
branch
from
1f31c97 to
aa510b9
Compare
June 22, 2025 15:57
nicoddemus
enabled auto-merge (squash)
June 22, 2025 15:59
nicoddemus
disabled auto-merge
June 22, 2025 16:40
Copy link
Copy Markdown
Backport to 8.4.x: 💚 backport PR created✅ Backport PR branch: patchback/backports/8.4.x/111685cc506fbaf87c105e67d68fbd881a47a84b/pr-13543 Backported as #13555 🤖 @patchback |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #13530
Summary
This PR addresses a decimal.FloatOperation error that happens when calling repr() on a pytest.approx object created with a decimal.Decimal value. The error arises from comparing and formatting Decimal and float values without proper conversion, which activates the FloatOperation trap.
Changes
I modified the repr method to carefully handle Decimal and float attributes. This is done by explicitly converting float values to Decimal before comparisons and formatting.
I added checks for None to prevent invalid comparisons.
I avoided direct comparisons between float and Decimal that can lead to FloatOperation exceptions.
Testing
I created a minimal test to reproduce the FloatOperation error from pytest.approx(Decimal)'s repr().
The test passes after applying this fix, confirming that the issue is resolved.