FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Defer annotation eval on Python 3.14 by cdce8p · Pull Request #13550 · pytest-dev/pytest · GitHub

/ pytest Public

Defer annotation eval on Python 3.14 - #13550

Merged
nicoddemus merged 3 commits into
pytest-dev:mainfrom
cdce8p-forks:314-signature
Jun 22, 2025
ConversationCommits (3)ChecksFiles changed
Merged

Defer annotation eval on Python 3.14#13550
nicoddemus merged 3 commits into
pytest-dev:mainfrom
cdce8p-forks:314-signature

Conversation

cdce8p commented Jun 21, 2025

Copy link
Copy Markdown
Contributor

Fixes #13549

psf-chronographer Bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jun 21, 2025
RonnyPfannschmidt approved these changes Jun 21, 2025
View reviewed changes

RonnyPfannschmidt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

well done, thanks

Comment thread src/_pytest/compat.py

cdce8p commented Jun 22, 2025

Copy link
Copy Markdown
Contributor Author

Anything else left here? The test failures look unrelated to me.

RonnyPfannschmidt commented Jun 22, 2025

Copy link
Copy Markdown
Member

Failures are unrelated
We are responsible for merging soon

nicoddemus reviewed Jun 22, 2025
View reviewed changes
Comment thread changelog/13549.bugfix.rst Outdated

nicoddemus commented Jun 22, 2025

Copy link
Copy Markdown
Member

Will merge after #13548.

nicoddemus approved these changes Jun 22, 2025
View reviewed changes

nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @cdce8p!

nicoddemus enabled auto-merge (squash) June 22, 2025 15:49
nicoddemus merged commit 8ca783c into pytest-dev:main Jun 22, 2025

patchback Bot commented Jun 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Backport to 8.4.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.4.x/8ca783cf4a3b4007f513a7446b7069d4dac52587/pr-13550

Backported as #13553

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Jun 22, 2025
Defer annotation eval on Python 3.14 (#13550)
eae6faa 
Fixes #13549

(cherry picked from commit 8ca783c)
patchback Bot mentioned this pull request Jun 22, 2025
Merged
nicoddemus pushed a commit that referenced this pull request Jun 22, 2025
Defer annotation eval on Python 3.14 (#13550) (#13553)
242522a 
Fixes #13549

(cherry picked from commit 8ca783c)

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
cdce8p deleted the 314-signature branch June 22, 2025 20:21
The-Compiler mentioned this pull request Sep 30, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

RonnyPfannschmidt RonnyPfannschmidt approved these changes
nicoddemus nicoddemus approved these changes
Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unresolved annotations shouldn't throw errors on Python 3.14

4 participants

Back | FazBrowse Home | New Git URL