FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[PR #13559] Added "int" & "float" to the argparsing type Literal by NayeemJohnY · Pull Request #13560 · pytest-dev/pytest · GitHub

/ pytest Public

[PR #13559] Added "int" & "float" to the argparsing type Literal - #13560

Merged
nicoddemus merged 7 commits into
pytest-dev:mainfrom
NayeemJohnY:patch-1
Jun 24, 2025
ConversationCommits (7)ChecksFiles changed
Merged

[PR #13559] Added "int" & "float" to the argparsing type Literal#13560
nicoddemus merged 7 commits into
pytest-dev:mainfrom
NayeemJohnY:patch-1

Conversation

NayeemJohnY commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Closes #13559
Added Supported 'int' & 'float' types are to valid type Literal.

NayeemJohnY changed the title Added "int" & "float" to the argparsing type Literal (Closes #13559) [PR #13543] Added "int" & "float" to the argparsing type Literal Jun 24, 2025
nicoddemus requested changes Jun 24, 2025
View reviewed changes

nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the PR @NayeemJohnY!

To be able to merge it, however, we still need:

  • Tests for each new option to ensure they work as intended and avoid future regressions.
  • A CHANGELOG entry.

NayeemJohnY changed the title [PR #13543] Added "int" & "float" to the argparsing type Literal [PR #13559] Added "int" & "float" to the argparsing type Literal Jun 24, 2025
psf-chronographer Bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jun 24, 2025

NayeemJohnY commented Jun 24, 2025

Copy link
Copy Markdown
Contributor Author

Thanks @nicoddemus for the feedback.
Added a CHANGELOG entry.
Test already exists for these 2 types. https://github.com/pytest-dev/pytest/blob/main/testing/test_config.py#L853-L927

Thanks.

NayeemJohnY requested a review from nicoddemus June 24, 2025 12:22

nicoddemus commented Jun 24, 2025

Copy link
Copy Markdown
Member

Ahh I see, thanks @NayeemJohnY!

nicoddemus enabled auto-merge (squash) June 24, 2025 16:31
nicoddemus merged commit ae73461 into pytest-dev:main Jun 24, 2025

patchback Bot commented Jun 24, 2025 •
edited
Loading

Copy link
Copy Markdown

Backport to 8.4.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.4.x/ae7346114d65e3a2c0ccd77af8a0ca00012cd91d/pr-13560

Backported as #13562

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Jun 24, 2025
Add int and float variants to Parser.addini (#13560)
8272386 
Fixes #13559.

---------

Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
(cherry picked from commit ae73461)
patchback Bot mentioned this pull request Jun 24, 2025
Merged
nicoddemus added a commit that referenced this pull request Jun 24, 2025
Add int and float variants to Parser.addini (#13560) (#13562)
d879a52 
Fixes #13559.

---------


(cherry picked from commit ae73461)

Co-authored-by: NayeemJohn <44828643+NayeemJohnY@users.noreply.github.com>
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

argparsing.py: Supported 'int' & 'float' types are not added to valid type Literal

2 participants

Back | FazBrowse Home | New Git URL