FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Handled CollectReport without duration attribute in terminal report by coder-aditi · Pull Request #13573 · pytest-dev/pytest · GitHub

/ pytest Public

Handled CollectReport without duration attribute in terminal report - #13573

Merged
nicoddemus merged 9 commits into
pytest-dev:mainfrom
coder-aditi:fix/pytest_terminal_report_issue
Jul 1, 2025
ConversationCommits (9)ChecksFiles changed
Merged

Handled CollectReport without duration attribute in terminal report#13573
nicoddemus merged 9 commits into
pytest-dev:mainfrom
coder-aditi:fix/pytest_terminal_report_issue

Conversation

coder-aditi commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

Fix #13478

This PR adds a regression test to fix a bug in console_output_style=times that, because it lacks the duration attribute, caused a crash when a CollectReport object (from a skipped test) was included. The test helps stop future regressions and verifies that the problem no longer exists.

nicoddemus requested changes Jun 28, 2025
View reviewed changes
Comment thread testing/test_terminal_report.py Outdated
print(result.stderr.str())

combined = result.stdout.lines + result.stderr.lines
assert any(

nicoddemus Jun 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not sure I follow, doesn't the change in terminal.py prevents this message from appearing in the command line?

coder-aditi Jun 28, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this fix mainly prevents the AttributeError from showing up, which is expected now asthe bug is resolved.

nicoddemus Jun 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

But the fact that the bug is fixed, means that the message does not show up, correct? any is testing that it should show up, which is wrong.

Comment thread testing/test_terminal_report.py Outdated
from _pytest.pytester import Pytester


def test_console_output_style_times_with_skipped_and_passed(pytester: Pytester) -> None:

nicoddemus Jun 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Any reason why this test is not added to test_terminal.py?

coder-aditi Jun 28, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @nicoddemus , test_terminal.py was already existing,, so thought of making another new unit test file. Shall I add this in that existing file only? please let me know

nicoddemus Jun 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes please. 👍

nicoddemus reviewed Jun 28, 2025
View reviewed changes
Comment thread testing/test_terminal_report.py Outdated

coder-aditi commented Jun 29, 2025

Copy link
Copy Markdown
Contributor Author

Hi @nicoddemus , I made the necessary changes, please review and let me know. Thank you.

psf-chronographer Bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jun 29, 2025
nicoddemus approved these changes Jun 29, 2025
View reviewed changes

nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

nicoddemus merged commit c5a75f2 into pytest-dev:main Jul 1, 2025

patchback Bot commented Jul 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Backport to 8.4.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.4.x/c5a75f2498c86850c4ce13bcf10d56efc92394a4/pr-13573

Backported as #13579

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Jul 1, 2025
Fix crash with times output style and skipped module (#13573)
3e8a268 
Fixes #13478

---------

Co-authored-by: AD <mysideuse@gmail.com>
Co-authored-by: Bruno Oliveira <bruno@pytest.org>
(cherry picked from commit c5a75f2)
patchback Bot mentioned this pull request Jul 1, 2025
Merged
nicoddemus added a commit that referenced this pull request Jul 1, 2025
Fix crash with times output style and skipped module (#13573) (#13579)
f87289c 
Fixes #13478

---------

(cherry picked from commit c5a75f2)

Co-authored-by: Aditi De <92822822+coder-aditi@users.noreply.github.com>
Co-authored-by: AD <mysideuse@gmail.com>
Co-authored-by: Bruno Oliveira <bruno@pytest.org>
pull Bot pushed a commit to mergify-ci-insights/pytest that referenced this pull request Jul 16, 2025
Fix crash with times output style and skipped module (pytest-dev#13573
275b7df 
)

Fixes pytest-dev#13478

---------

Co-authored-by: AD <mysideuse@gmail.com>
Co-authored-by: Bruno Oliveira <bruno@pytest.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash with console_output_style=times and skipping tests

3 participants

Back | FazBrowse Home | New Git URL