Remove unintentionally-unconditional skips - #13842
Merged
bluetech merged 5 commits intoOct 25, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I was initially going to use the trivial changelog type, but apparently that was removed in #12501. I've updated CONTRIBUTING.rst to match |
Sorry, something went wrong.
bluetech
reviewed
Oct 24, 2025
bluetech
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for catching this.
Sorry, something went wrong.
Comment thread
testing/_py/test_local.py
Outdated
Comment thread
CONTRIBUTING.rst
Comment thread
changelog/13842.contrib.rst
Outdated
bluetech
approved these changes
Oct 25, 2025
bluetech
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks Ran! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest.mark.skip("string condition") always skips. I assume these were meant to be pytest.mark.skipif.
Do test-only fixes need a changelog entry? (Yes, at least according to CI)