| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
well done, i wish GH had a merge on pass button |
Sorry, something went wrong.
|
Thanks! @rabbbit could you review as well, and perhaps even try it? Would hate for this to be merged only to discover after the release it still does not fit your needs and others. |
Sorry, something went wrong.
|
Does github have any badge options I could give you? :) 👍 Yeah, it looks awesome. I wouldn't bother with the bool-parsing, and I have troubles understanding actual code, but functionality wise it looks perfect. |
Sorry, something went wrong.
Add a "strict" parameter to xfail
|
we should consider re-priming the xfail result to also handle setup/teardown xfails instead of just doing a fail on exit i wonder if xpass in strict mode should always report to the terminal :) |
Sorry, something went wrong.
|
Missed the CHANGELOG, I will just push it directly to master |
Sorry, something went wrong.
|
Thanks for merging it!
What do you mean by "re-priming"?
The current implementation fails the test entirely... or do you mean something else? |
Sorry, something went wrong.
|
what i meant is that a) instead of running fail in the pyfunc_call, we should let a normal xfail propagate |
Sorry, something went wrong.
| @@ -178,6 +184,18 @@ def pytest_runtest_setup(item): | |||
|
|
|||
| def pytest_pyfunc_call(pyfuncitem): | |||
There was a problem hiding this comment.
Just realized this is the wrong hook for this. 😦
It is not executing the test at all when strict is True... I will fix this later tonight. 😞
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Fix #1355