FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

support `--show-capture` with `--tb=line` by zaplapl · Pull Request #13868 · pytest-dev/pytest · GitHub

/ pytest Public

support --show-capture with --tb=line - #13868

Merged
nicoddemus merged 11 commits into
pytest-dev:mainfrom
zaplapl:main
Nov 3, 2025
ConversationCommits (11)ChecksFiles changed
Merged

support --show-capture with --tb=line#13868
nicoddemus merged 11 commits into
pytest-dev:mainfrom
zaplapl:main

Conversation

zaplapl commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

closes #13865 by duplicating self._outrep_summary(rep) invocation during summary_failures_combined

considered refactoring into something like:

        for rep in reports:
            self._outrep_summary(rep)
                if style == "line":
                        line = self._getcrashline(rep)
                        self.write_line(line)
                else:
                        msg = self._getfailureheadline(rep)
                        self.write_sep("_", msg, red=True, bold=True)
                        self._handle_teardown_sections(rep.nodeid)

to avoid committing too hard to the branching logic in the code

but submitting this commit instead since it has fewer side-effects

zaplapl and others added 5 commits November 2, 2025 18:57
Update test_terminal.py
17610a3 
Assert output includes `- Captured stdout call -`
Update terminal.py
a779953 
add outrep summary to report when the formatting style is set to `line`
[pre-commit.ci] auto fixes from pre-commit.com hooks
16f5147 
for more information, see https://pre-commit.ci
Update AUTHORS
43eae28
Create 13865.bugfix.rst
7c94d06
psf-chronographer Bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Nov 2, 2025
nicoddemus requested changes Nov 3, 2025
View reviewed changes

nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @zaplapl for the PR, please take a look at my comments.

Comment thread testing/test_terminal.py Outdated
Comment thread changelog/13865.bugfix.rst Outdated
zaplapl and others added 3 commits November 3, 2025 18:59
Update changelog/13865.bugfix.rst
d24a30c 
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
Update testing/test_terminal.py
159c488 
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
[pre-commit.ci] auto fixes from pre-commit.com hooks
aa1df8a 
for more information, see https://pre-commit.ci
nicoddemus approved these changes Nov 3, 2025
View reviewed changes

nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

nicoddemus enabled auto-merge (squash) November 3, 2025 22:25
nicoddemus merged commit 76910ca into pytest-dev:main Nov 3, 2025
33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--show-capture not working when --tb=line

2 participants

Back | FazBrowse Home | New Git URL