FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add --report-chars long option and its corresponding test by junhaoliao · Pull Request #14024 · pytest-dev/pytest · GitHub

/ pytest Public

feat: add --report-chars long option and its corresponding test - #14024

Merged
jakkdl merged 10 commits into
pytest-dev:mainfrom
junhaoliao:report-chars
Dec 8, 2025
ConversationCommits (10)ChecksFiles changed
Merged

feat: add --report-chars long option and its corresponding test#14024
jakkdl merged 10 commits into
pytest-dev:mainfrom
junhaoliao:report-chars

Conversation

junhaoliao commented Dec 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

closes #14023

This change introduces a long-form CLI option --report-chars as an alternative to the existing
short -r option.

Here is a quick checklist that should be present in PRs.

  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.
  • Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.

If this change fixes an issue, please:

  • Add text like closes #XYZW to the PR description and/or commits (where XYZW is the issue number). See the github docs for more information.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.

    Write sentences in the past or present tense, examples:

    • Improved verbose diff output with sequences.
    • Terminal summary statistics now use multiple colors.

    Also make sure to end the sentence with a ..

  • Add yourself to AUTHORS in alphabetical order.

psf-chronographer Bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Dec 2, 2025
junhaoliao marked this pull request as ready for review December 2, 2025 07:15
jakkdl reviewed Dec 2, 2025
View reviewed changes
Comment thread testing/test_config.py Outdated
junhaoliao requested a review from jakkdl December 2, 2025 18:24

junhaoliao commented Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

Hi @jakkdl , I tried parameterizing the test case as instructed. Do you mind taking a look again?

jakkdl commented Dec 4, 2025

Copy link
Copy Markdown
Member

rewrote the parametrize to be slightly cleaner :)

Looking at --help I'm seeing a small discrepancy where some long options are displayed with a
= before the value and some aren't - but that's not limited to this option.

  --deselect=nodeid_prefix
  --doctest-glob=pat
  --lfnf, --last-failed-no-failures={all,none}

vs

  -r, --report-chars chars
  -c, --config-file FILE

but I don't think it really matters.

I'll merge this in a few days unless somebody pops in and notices something, thank you!

jakkdl enabled auto-merge December 8, 2025 12:01
jakkdl merged commit 324ef94 into pytest-dev:main Dec 8, 2025
33 checks passed

nicoddemus commented Dec 8, 2025

Copy link
Copy Markdown
Member

Thanks @junhaoliao for the PR and @jakkdl for merging!

@jakkdl just a note, in the future prefer to squash the commits when they by themselves are not very valuable to keep in the history (for example, "add changelog", "precommit fixes", etc).

Thanks again folks!

junhaoliao deleted the report-chars branch December 9, 2025 12:41
junhaoliao mentioned this pull request Dec 9, 2025
Merged
3 tasks
coderabbitai Bot mentioned this pull request Dec 9, 2025
Open

jakkdl commented Dec 10, 2025

Copy link
Copy Markdown
Member

frick sorry, not the first time it happened. I used to have a monkeyscript that warned about it but it appears to have gotten disabled at some point.

nicoddemus commented Dec 12, 2025

Copy link
Copy Markdown
Member

No worries!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jakkdl jakkdl approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a long form "--report-chars" to pytest.

3 participants

Back | FazBrowse Home | New Git URL