FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

don't crash if exceptiongroup has only hidden tb frames by jakkdl · Pull Request #14025 · pytest-dev/pytest · GitHub

/ pytest Public

don't crash if exceptiongroup has only hidden tb frames - #14025

Merged
jakkdl merged 5 commits into
pytest-dev:mainfrom
jakkdl:hide_tb
Dec 12, 2025
ConversationCommits (5)ChecksFiles changed
Merged

don't crash if exceptiongroup has only hidden tb frames#14025
jakkdl merged 5 commits into
pytest-dev:mainfrom
jakkdl:hide_tb

Conversation

jakkdl commented Dec 2, 2025

Copy link
Copy Markdown
Member

fixes #13734

yet another bandaid that would've been avoided if we had full support for exception groups in ExceptionInfo & friends 😶 see #9159

psf-chronographer Bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Dec 2, 2025
webknjaz approved these changes Dec 2, 2025
View reviewed changes

webknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, short of one cosmetic improvement request.

Comment thread testing/code/test_excinfo.py Outdated

jakkdl commented Dec 8, 2025

Copy link
Copy Markdown
Member Author

I played around a bit with the test and noticed that "tbstyle=line" now outputs "All traceback entries are hidden", and "ValueError: bar" will match in all cases. So I removed/updated the relevant if statements.
I don't think this is a bug or anything, just the test not being kept up to date with feature changes.

jakkdl merged commit fa6a232 into pytest-dev:main Dec 12, 2025
33 checks passed
jakkdl deleted the hide_tb branch December 12, 2025 15:15

patchback Bot commented Dec 14, 2025 •
edited
Loading

Copy link
Copy Markdown

Backport to 9.0.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/9.0.x/fa6a232d529b33f6388dc788d7613cf206c08130/pr-14025

Backported as #14045

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Dec 14, 2025
don't crash if exceptiongroup has only hidden tb frames (#14025)
99b2d79 
* don't crash if exceptiongroup has only hidden tb frames

(cherry picked from commit fa6a232)
patchback Bot mentioned this pull request Dec 14, 2025
Merged
nicoddemus pushed a commit that referenced this pull request Dec 14, 2025
don't crash if exceptiongroup has only hidden tb frames (#14025) (#14045
9a70eba 
)

* don't crash if exceptiongroup has only hidden tb frames

(cherry picked from commit fa6a232)

Co-authored-by: John Litborn <11260241+jakkdl@users.noreply.github.com>
jakkdl mentioned this pull request Dec 15, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

webknjaz webknjaz approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IndexError if all post-cut traceback frames are hidden

3 participants

Back | FazBrowse Home | New Git URL