assertion/util: improve typing - #14383
Merged
bluetech merged 3 commits intoMay 1, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Change `Any`s to `object`. It's better to use `object` for "unknown" -- `object` is type safe, `Any` is not. To aid in this, change the `is*` functions to TypeGuards, so their check is carried over to the typing. Since pytest already uses dataclasses extensively internally, I removed the lazy import of it, this way can more easily utilize the existing type guard from typeshed.
Comment thread
src/_pytest/assertion/util.py
|
|
||
|
|
||
| def isiterable(obj: Any) -> bool: | ||
| def isiterable(obj: object) -> TypeGuard[collections.abc.Iterable[object]]: |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This one should take object|Iterable[object]
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Iterable[object] is a subtype of object, so isn't this equivalent to object?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Anys to object. It's better to use object for "unknown" -- object is type safe, Any is not.
To aid in this, change the is* functions to TypeGuards, so their check is carried over to the typing.
Since pytest already uses dataclasses extensively internally, I removed the lazy import of it, this way can more easily utilize the existing type guard from typeshed.