fix mark expression scanner: search for backslash in string value, not entire input - #14475
Merged
bluetech merged 3 commits intoMay 13, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…t entire input
The backslash check in the string literal lexer was searching the entire
input expression instead of only the current string value. This caused
false rejections when an identifier containing a backslash appeared in the
same expression as a string literal.
Changed input.find("\\") to value.find("\\") and adjusted the column
offset from backslash_pos + 1 to pos + backslash_pos + 1 so the error
points to the correct position when a backslash is inside a string.
Closes pytest-dev#14474
The test_backslash_in_identifier_with_string_literal test was failing because the matcher function only recognized '\nfoo\n' as a valid identifier. When the expression contained 'mark(x="y")', the matcher returned False for 'mark', causing the entire 'and' expression to evaluate to False instead of True.
bluetech
approved these changes
May 13, 2026
bluetech
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Look good, thanks!
Sorry, something went wrong.
Comment thread
changelog/14474.bugfix.rst
Outdated
Copy link
Copy Markdown
Backport to 9.0.x: 💚 backport PR created✅ Backport PR branch: patchback/backports/9.0.x/984cabfaccf8aa69fe49097ed3d07bd60d05f240/pr-14475 Backported as #14478 🤖 @patchback |
Sorry, something went wrong.
bluetech
added a commit
that referenced
this pull request
May 14, 2026
…84cabfaccf8aa69fe49097ed3d07bd60d05f240/pr-14475 [PR #14475/984cabfa backport][9.0.x] fix mark expression scanner: search for backslash in string value, not entire input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backslash check in the string literal lexer was searching the entire input expression (input.find("\")) instead of only the current string value (value.find("\")). This caused false rejections when an identifier containing a backslash appeared in the same expression as a string literal.
For example, pytest -k 'test\nfoo\n and mark(x="y")' would fail with "escaping not supported" even though the backslash is in the identifier, not the string.
The fix:
Added a regression test for the case where backslashes in identifiers coexist with string literals in the same expression.
Closes #14474