Summary:
Improve equality assertion explanations for objects implementing collections.abc.Mapping, not only concrete dict instances.
Previously, non-dict mapping objects could fall through to the generic iterable comparison path, even though the existing mapping comparison logic already works with the Mapping protocol. This updates the dispatch check accordingly and renames the internal helper from dict-specific wording to mapping-specific wording.
Details:
This keeps the change intentionally narrow:
use Mapping for the assertion comparison dispatch
rename the internal helper to match the broader behavior
add a focused regression test with a small custom Mapping
add a changelog fragment
add myself to AUTHORS
I avoided adding coverage for third-party mapping libraries here, since those can have different key/value semantics and would make this PR broader than necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Improve equality assertion explanations for objects implementing collections.abc.Mapping, not only concrete dict instances.
Previously, non-dict mapping objects could fall through to the generic iterable comparison path, even though the existing mapping comparison logic already works with the Mapping protocol. This updates the dispatch check accordingly and renames the internal helper from dict-specific wording to mapping-specific wording.
Closes #14461.
Details:
This keeps the change intentionally narrow:
I avoided adding coverage for third-party mapping libraries here, since those can have different key/value semantics and would make this PR broader than necessary.
Tests:
Result: 6 passed
PYTHONPATH=src .venv/bin/python -m pytest \ testing/test_assertion.py::TestAssert_reprcompare \ -k "dict or mapping" \ -q -sResult: 8 passed, 34 deselected