Show invalid ini keys sorted - #7303
Merged
asottile merged 1 commit intoJun 2, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Otherwise this relies on the dictionary order of `config.inicfg`, which is insertion order in py36+ but "random" order in py35.
nicoddemus
force-pushed
the
flaky-ini-keys
branch
from
00cb162 to
8ac18bb
Compare
June 2, 2020 19:09
asottile
approved these changes
Jun 2, 2020
asottile
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Sorry about that. Thanks for patching @asottile and @nicoddemus |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Not at all @gnikonorov, thanks again for the original contribution! 👍 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise this relies on the dictionary order of config.inicfg, which
is insertion order in py36+ but "random" order in py35.
This lead to an unrelated failure in https://github.com/pytest-dev/pytest/pull/7247/checks?check_run_id=732077801.