FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use exact comparison for bool in approx() by jvansanten · Pull Request #9354 · pytest-dev/pytest · GitHub

/ pytest Public

Use exact comparison for bool in approx() - #9354

Merged
nicoddemus merged 5 commits into
pytest-dev:mainfrom
jvansanten:issue-9353
Nov 29, 2024
ConversationCommits (5)ChecksFiles changed
Merged

Use exact comparison for bool in approx()#9354
nicoddemus merged 5 commits into
pytest-dev:mainfrom
jvansanten:issue-9353

Conversation

jvansanten commented Nov 30, 2021

Copy link
Copy Markdown
Contributor

Fixes #9353.

nicoddemus commented Jun 14, 2022

Copy link
Copy Markdown
Member

Hi @jvansanten,

Was taking a look at the list of PRs and this one seems to have gone unnoticed, sorry about that.

Overall all changes look good to me, I left a comment about the changelog only. Would you like to finish it up? If you don't have the time please let us know so we can do it. Thanks, and sorry for the delay again!

nicoddemus reviewed Jun 14, 2022
View reviewed changes
Comment thread changelog/9353.bugfix.rst Outdated
Reword changelog
9e5243a 
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
RonnyPfannschmidt reviewed Jun 14, 2022
View reviewed changes

RonnyPfannschmidt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For approx of bool, doesn't it semantically make sense to check for truthy values when requested explicitly, but also ensure is checks for implicit matches in lists mappings

marcelotrevisani commented Nov 29, 2024

Copy link
Copy Markdown
Contributor

hey, I just got into this problems these days and found this PR. What is it missing to get this over the line please?

nicoddemus commented Nov 29, 2024

Copy link
Copy Markdown
Member

Seems this fell through the cracks, thanks for the ping. I will rebase.

@RonnyPfannschmidt anything else you would like changed here before we merge it?

psf-chronographer Bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Nov 29, 2024

nicoddemus commented Nov 29, 2024

Copy link
Copy Markdown
Member

Will squash/merge in the next few days. Thanks @jvansanten for the PR and sorry that we missed this one. Also thanks @marcelotrevisani for the ping!

RonnyPfannschmidt approved these changes Nov 29, 2024
View reviewed changes

RonnyPfannschmidt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

its good as is atm - the more tricky details are for when we implement matchers

nicoddemus merged commit a16e8ea into pytest-dev:main Nov 29, 2024

patchback Bot commented Nov 29, 2024 •
edited
Loading

Copy link
Copy Markdown

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/a16e8eac8c91b8d0f91c461a4de39adbf8a75b0f/pr-9354

Backported as #13013

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot mentioned this pull request Nov 29, 2024
Merged
t-b mentioned this pull request Dec 9, 2024
Closed
malangsiddharth mentioned this pull request Jan 14, 2025
Closed
yuyichao added a commit to euriqa-brassboard/brassboard-seq that referenced this pull request Feb 12, 2025
Workaround pytest breaking change
ff6e6fb 
Also fix list comparison that was only comparing the first element...

Ref pytest-dev/pytest#9354
Ref pytest-dev/pytest#13218
callummscott mentioned this pull request Apr 2, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

RonnyPfannschmidt RonnyPfannschmidt approved these changes
nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pytest.approx considers boolean numeric types

4 participants

Back | FazBrowse Home | New Git URL