FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve error message in getfixturevalue by petebman · Pull Request #9990 · pytest-dev/pytest · GitHub

Improve error message in getfixturevalue - #9990

Merged
Zac-HD merged 1 commit into
pytest-dev:mainfrom
petebman:improve_getfixturevalue_error_message
May 28, 2022
Merged

Improve error message in getfixturevalue#9990
Zac-HD merged 1 commit into
pytest-dev:mainfrom
petebman:improve_getfixturevalue_error_message

Conversation

Copy link
Copy Markdown
Contributor
  • Improve the error message when we attempt to access a fixture that has been
    torn down.

  • Add an additional sentence to the docstring explaining when it's not a good
    idea to call getfixturevalue.

closes #9984

nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

Zac-HD left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the patch @petebman!

Zac-HD merged commit 420dc78 into pytest-dev:main May 28, 2022
petebman deleted the improve_getfixturevalue_error_message branch May 31, 2022 17:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

request.getfixturevalue crashes in certain cases.

3 participants


Back | FazBrowse Home | New Git URL