test: cover timeout setup outside the main thread - #208
Open
hfycium wants to merge 1 commit into
Open
hfycium wants to merge 1 commit into
hfycium wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
All CI checks are passing on Python 3.10–3.14 across Ubuntu and Windows. The PR only updates the regression test for #158 and is ready for review. Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158.
The existing test_not_main_thread was permanently skipped because it referenced the removed pytest_timeout.timeout_setup function. Rework it to exercise the current pytest_timeout_set_timer hook from a worker thread, preserving coverage for the fallback from the signal method to the thread method.
Validation: