Don't pass maintainer_can_modify when patching the PR. - #163
Merged
Mariatta merged 1 commit intoApr 8, 2019
Merged
Mariatta merged 1 commit into
Mariatta merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 1529 1529
Branches 86 86
=====================================
Hits 1529 1529
Continue to review full report at Codecov.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I've deployed, and went through all the failed webhook deliveries fro the past 2 days. Things seem to be looking better now: PR's edited with link to bpo, bedevere statuses are being posted, and it still seems like I'm still able to edit the affected PRs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to need to pass the maintainer_can_modify flag, but now we're getting error message 422 Validation Failed for 'maintainer_can_modify' when patching the PR. (to append the bpo link)
Removing the maintainer_can_modify flag fixes the problem, I tested in command line.
Hopefully this quick fix can unblock people.
Perhaps something changed from GitHub side, but I'm not seeing anything obvious in their changelog.
Closes #162
Closes python/core-workflow#321