Move Ruff config to pyproject.toml - #81
Conversation
Sorry, something went wrong.
| @@ -1,16 +0,0 @@ | |||
| target-version = "py310" | |||
There was a problem hiding this comment.
Not needed in pyproject.toml because Ruff will get it from requires-python = ">=3.10".
https://docs.astral.sh/ruff/configuration/#inferring-the-python-version
Sorry, something went wrong.
| [tool.ruff] | ||
| fix = true | ||
| format.preview = true | ||
| format.quote-style = "single" |
There was a problem hiding this comment.
Thoughts on dropping this and using the default double?
Sorry, something went wrong.
There was a problem hiding this comment.
I'd suggest dropping this altogether, I don't think consistent quotes are important enough for the linter to annoy us about them.
Sorry, something went wrong.
There was a problem hiding this comment.
Reverted!
Sorry, something went wrong.
| readme = "README.md" | ||
| maintainers = [ | ||
| { name = "Python Core Developers", email = "core-workflow@mail.python.org" }, | ||
| { name = "Python Core Team", email = "core-workflow@mail.python.org" }, |
There was a problem hiding this comment.
Hmm, that email probably won't work any more. But I don't think we have a better alternative?
Sorry, something went wrong.
There was a problem hiding this comment.
Indeed:
550 5.1.1 : Recipient address rejected: User unknown Contact your postmaster/admin for assistance.
Let's remove the email address (in another PR), it's not required.
Sorry, something went wrong.
This reverts commit a8c6acc.
StanFromIreland
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
It makes it easier to diff other projects when the config is centralised in the usual place.
Also update pre-commit hooks and change maintainers' name from "Python Core Developers" to "Python Core Team".