FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

In Android tests, disable Gradle daemon by mhsmith · Pull Request #796 · python/buildmaster-config · GitHub

  1. python
  2. buildmaster-config

Repository navigation

In Android tests, disable Gradle daemon - #796

Merged
vstinner merged 3 commits into
python:mainfrom
mhsmith:android-no-daemon
Sep 16, 2026
ConversationCommits (3)ChecksFiles changed
Merged

In Android tests, disable Gradle daemon#796
vstinner merged 3 commits into
python:mainfrom
mhsmith:android-no-daemon

Conversation

mhsmith commented Sep 16, 2026

Copy link
Copy Markdown
Member

This should fix the problem discussed at python/cpython#155518 (comment).

mhsmith changed the title Android no daemon In Android tests, disable Gradle daemon Sep 16, 2026
This was referenced Sep 16, 2026
Merged
Merged
Merged
mhsmith requested a review from vstinner September 16, 2026 13:24
vstinner reviewed Sep 16, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't know well Android. I don't know what is this -Dorg.gradle.daemon=false option. Does it disable a Gradle daemon? Maybe say it in the test_environ comment.

Comment thread master/custom/factories.py
"""

# Make each run more independent
# (https://github.com/python/cpython/pull/155518#issuecomment-5259725142).

vstinner Sep 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You might copy/paste the comment rather than adding a link.

mhsmith Sep 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've added some details to the comment, but I think it's worth keeping the link in case any more details are added to the issue in the future.

mhsmith requested a review from vstinner September 16, 2026 14:03
vstinner approved these changes Sep 16, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The change looks good to me, but I'm not an Android expert.

vstinner commented Sep 16, 2026

Copy link
Copy Markdown
Member

Should we backport the change (you didn't add the "backport" labels)?

mhsmith commented Sep 16, 2026

Copy link
Copy Markdown
Member Author

There are no backports in this repository, are there?

vstinner commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Oh! I read quickly the PR, I saw Platforms/Android/, and so I expected the PR to be on Python. But that's a buildbot change! You're right, no backport is needed.

vstinner merged commit 01587a7 into python:main Sep 16, 2026
1 check passed

vstinner commented Sep 16, 2026

Copy link
Copy Markdown
Member

Merged. Thanks for the long comment, its useful to me!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL