FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix detection of upstream version branches with continue by abadger · Pull Request #265 · python/core-workflow · GitHub

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion cherry_picker/cherry_picker/cherry_picker.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ def get_base_branch(cherry_pick_branch):
"""
return '2.7' from 'backport-sha-2.7'
"""
prefix, sep, base_branch = cherry_pick_branch.rpartition('-')
prefix, sha, base_branch = cherry_pick_branch.split('-', 2)
return base_branch


Expand Down
7 changes: 4 additions & 3 deletions cherry_picker/cherry_picker/test.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,16 @@ def changedir(d):


def test_get_base_branch():
# The format of cherry-pick branches we create are "backport-{SHA}-{base_branch}"
cherry_pick_branch = 'backport-afc23f4-2.7'
result = get_base_branch(cherry_pick_branch)
assert result == '2.7'


def test_get_base_branch_without_dash():
cherry_pick_branch ='master'
def test_get_base_branch_which_has_dashes():
cherry_pick_branch ='backport-afc23f4-baseprefix-2.7-basesuffix'
result = get_base_branch(cherry_pick_branch)
assert result == 'master'
assert result == 'baseprefix-2.7-basesuffix'


@mock.patch('subprocess.check_output')
Expand Down

Back | FazBrowse Home | New Git URL