FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Relax click dependency. by asvetlov · Pull Request #302 · python/core-workflow · GitHub

/ core-workflow Public

Relax click dependency. - #302

Merged
Mariatta merged 2 commits into
masterfrom
relax-click-dependency
Jan 13, 2019
ConversationCommits (2)ChecksFiles changed
Merged

Relax click dependency.#302
Mariatta merged 2 commits into
masterfrom
relax-click-dependency

Conversation

asvetlov commented Jan 13, 2019

Copy link
Copy Markdown
Contributor

Allow to install cherry_picker with the modern click version

Relax click dependency.
33b1de7 
Allow to install cherry_picker with the modern click version
asvetlov requested a review from Mariatta as a code owner January 13, 2019 13:48
willingc approved these changes Jan 13, 2019
View reviewed changes

willingc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks @asvetlov.

Mariatta merged commit bff4148 into master Jan 13, 2019
Mariatta deleted the relax-click-dependency branch January 13, 2019 19:59

Mariatta commented Jan 13, 2019

Copy link
Copy Markdown
Member

Thanks! Do you need a release cut?

asvetlov commented Jan 13, 2019

Copy link
Copy Markdown
Contributor Author

It would be nice!

Mariatta commented Jan 13, 2019

Copy link
Copy Markdown
Member

Can you increase/update the version info, and the changelog?
Similar to https://github.com/python/core-workflow/pull/282/files

After that, create a GitHub tag of the release branch, and it will be automatically released to PyPI.

There's a brief write-up here: https://github.com/python/core-workflow/tree/master/cherry_picker#publishing-to-pypi

asvetlov commented Jan 13, 2019

Copy link
Copy Markdown
Contributor Author

Will try

Mariatta commented Jan 24, 2019

Copy link
Copy Markdown
Member

v1.2.2 is now on PyPI

webknjaz reviewed Feb 9, 2019
View reviewed changes
Comment thread cherry_picker/cherry_picker/cherry_picker.py
help=("Path to config file, .cherry_picker.toml "
"from project root by default"),
default=None)
@click.argument('commit_sha1', 'The commit sha1 to be cherry-picked', nargs=1,

webknjaz Feb 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why remove the explanation? How is this related to the click dependency update?

webknjaz Feb 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

oh, they changed api..

asvetlov Feb 10, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Explicitly forbade meaningless argument actually. The help was never displayed IIRC

webknjaz Feb 10, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh, nevermind. I've already figured out that it fails with this arg under newer Click: https://travis-ci.org/python/core-workflow/jobs/491106736#L270

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

webknjaz webknjaz left review comments
willingc willingc approved these changes
Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

cherry_picker.py CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL