FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

cherry-picker: Run Travis CI test on Windows by encukou · Pull Request #311 · python/core-workflow · GitHub

cherry-picker: Run Travis CI test on Windows - #311

Merged
Mariatta merged 8 commits into
python:masterfrom
encukou:travis-windows
Mar 16, 2019
Merged

cherry-picker: Run Travis CI test on Windows#311
Mariatta merged 8 commits into
python:masterfrom
encukou:travis-windows

Conversation

encukou commented Feb 22, 2019

Copy link
Copy Markdown
Member

I've set up a Windows build on Travis before, maybe I can help #296 a bit!
There's no Python pre-installed, but there's a package manager, choco, that can install it.

Currently, the tests fail because they seem to require Git's user.email and user.name to be set globally. They fail on my dev machine as well, since I don't have an e-mail set globally (I use different e-mail addresses on different repos).
Sadly, I can't devote time to fixing that issue, but I can help to reproduce or explain more if needed.

To try out changes privately, here's what I do:

  • Enable Travis on your fork of the repo
  • Uncheck "Build pused branches" and "Build pushed pull requests" on your fork's Travis settings (you'll want to trigger builds manually)
  • Push code you want to test to your fork's master branch
  • Use "Trigger build in Travis's "More options" menu to trigger the build
  • Cancel any builds you're not interested in (for example, all the Linux builds) to save both time and processing

Comment thread .travis.yml
Comment thread .travis.yml Outdated

Copy link
Copy Markdown
Member

It should be easy to fix tests by extending this fixture (https://github.com/python/core-workflow/blob/b3c68fe/cherry_picker/cherry_picker/test.py#L87-L91) to set local user and email in config.

encukou commented Feb 22, 2019

Copy link
Copy Markdown
Member Author

Oh, one more thing I meant to put in the initial comment:

Unfortunately I probably won't find much time to tend to this PR properly. Feel free to make changes directly to the branch, that'll make things much faster.

Copy link
Copy Markdown
Member

Another thing is that Travis CI seems to be going down now: ansible/molecule#1770

Comment thread .travis.yml Outdated
encukou requested a review from Mariatta as a code owner March 15, 2019 18:43

Copy link
Copy Markdown
Member

Git config related tests fixed. Now, there's two Unicode-related failures.

Copy link
Copy Markdown
Member

@Mariatta please merge it, it's ready.

Copy link
Copy Markdown
Member

Thanks!!

Mariatta merged commit 9cf0ac1 into python:master Mar 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL