FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.13] gh-123401: Fix http.cookies module to support obsolete RFC 850… · python/cpython@a94e20e · GitHub

/ cpython Public

Commit a94e20e

Browse files
authored
[3.13] gh-123401: Fix http.cookies module to support obsolete RFC 850 date format (GH-123405) (#127828)
gh-123401: Fix http.cookies module to support obsolete RFC 850 date format (GH-123405) (cherry picked from commit 359389e) Co-authored-by: Nano <nanoapezlk@gmail.com> Co-authored-by: Wulian <1055917385@qq.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
1 parent bcdd10d commit a94e20e

3 files changed

Lines changed: 53 additions & 2 deletions

File tree

‎Lib/http/cookies.py‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -424,9 +424,11 @@ def OutputString(self, attrs=None):
424424
( # Optional group: there may not be a value.
425425
\s*=\s* # Equal Sign
426426
(?P<val> # Start of group 'val'
427-
"(?:[^\\"]|\\.)*" # Any doublequoted string
427+
"(?:[^\\"]|\\.)*" # Any double-quoted string
428428
| # or
429-
\w{3},\s[\w\d\s-]{9,11}\s[\d:]{8}\sGMT # Special case for "expires" attr
429+
# Special case for "expires" attr
430+
(\w{3,6}day|\w{3}),\s # Day of the week or abbreviated day
431+
[\w\d\s-]{9,11}\s[\d:]{8}\sGMT # Date and time in specific format
430432
| # or
431433
[""" + _LegalValueChars + r"""]* # Any word or empty string
432434
) # End of group 'val'

‎Lib/test/test_http_cookies.py‎

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,52 @@ def test_basic(self):
5959
for k, v in sorted(case['dict'].items()):
6060
self.assertEqual(C[k].value, v)
6161

62+
def test_obsolete_rfc850_date_format(self):
63+
# Test cases with different days and dates in obsolete RFC 850 format
64+
test_cases = [
65+
# from RFC 850, change EST to GMT
66+
# https://datatracker.ietf.org/doc/html/rfc850#section-2
67+
{
68+
'data': 'key=value; expires=Saturday, 01-Jan-83 00:00:00 GMT',
69+
'output': 'Saturday, 01-Jan-83 00:00:00 GMT'
70+
},
71+
{
72+
'data': 'key=value; expires=Friday, 19-Nov-82 16:59:30 GMT',
73+
'output': 'Friday, 19-Nov-82 16:59:30 GMT'
74+
},
75+
# from RFC 9110
76+
# https://www.rfc-editor.org/rfc/rfc9110.html#section-5.6.7-6
77+
{
78+
'data': 'key=value; expires=Sunday, 06-Nov-94 08:49:37 GMT',
79+
'output': 'Sunday, 06-Nov-94 08:49:37 GMT'
80+
},
81+
# other test cases
82+
{
83+
'data': 'key=value; expires=Wednesday, 09-Nov-94 08:49:37 GMT',
84+
'output': 'Wednesday, 09-Nov-94 08:49:37 GMT'
85+
},
86+
{
87+
'data': 'key=value; expires=Friday, 11-Nov-94 08:49:37 GMT',
88+
'output': 'Friday, 11-Nov-94 08:49:37 GMT'
89+
},
90+
{
91+
'data': 'key=value; expires=Monday, 14-Nov-94 08:49:37 GMT',
92+
'output': 'Monday, 14-Nov-94 08:49:37 GMT'
93+
},
94+
]
95+
96+
for case in test_cases:
97+
with self.subTest(data=case['data']):
98+
C = cookies.SimpleCookie()
99+
C.load(case['data'])
100+
101+
# Extract the cookie name from the data string
102+
cookie_name = case['data'].split('=')[0]
103+
104+
# Check if the cookie is loaded correctly
105+
self.assertIn(cookie_name, C)
106+
self.assertEqual(C[cookie_name].get('expires'), case['output'])
107+
62108
def test_unquote(self):
63109
cases = [
64110
(r'a="b=\""', 'b="'),

‎Misc/NEWS.d/next/Library/2024-08-27-18-58-01.gh-issue-123401.t4-FpI.rst‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
The :mod:`http.cookies` module now supports parsing obsolete :rfc:`850`
2+
date formats, in accordance with :rfc:`9110` requirements.
3+
Patch by Nano Zheng.

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL