gh-123401: Fix http.cookies module to support obsolete RFC 850 date format by Konano · Pull Request #123405 · python/cpython · GitHub

Issue: http.cookies module does not parse obsolete RFC 850 date format #123401

…date format

All commit authors signed the Contributor License Agreement.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Fix a minor typo in the regex comment by adding a hyphen to "double-quoted" for consistency and clarity. No functional changes to the code logic. Co-authored-by: Wulian <1055917385@qq.com>

@zware Could you please take a look at this PR when you are free? Thanks!

…4-FpI.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

At first glance it seems correct. I'm a bit tired for more in-depth review (and even if I were to approve it, a core dev is needed for merging it) so I'll leave it at it for today.

…4-FpI.rst

Is anyone available to follow up on this PR? Thanks!

Actually, I'm not sure who to contact...

You can request for review on https://discuss.python.org/c/core-dev/23 🙂

LGTM. Thanks for the tests.

I couldn't merge the PR since some mandatory CI jobs didn't run. I clicked on [Update branch]. Let's see if it does unblock the issue.

Merged, thanks @Konano.

Does this PR need to be backported to other versions? @vstinner

Thanks @Konano for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

…date format (pythonGH-123405) (cherry picked from commit 359389e) Co-authored-by: Nano <nanoapezlk@gmail.com> Co-authored-by: Wulian <1055917385@qq.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>

GH-127828 is a backport of this pull request to the 3.13 branch.

Thanks @Konano for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

…date format (pythonGH-123405) (cherry picked from commit 359389e) Co-authored-by: Nano <nanoapezlk@gmail.com> Co-authored-by: Wulian <1055917385@qq.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>

GH-127829 is a backport of this pull request to the 3.12 branch.

Does this PR need to be backported to other versions? @vstinner

I created backports to 3.12 and 3.13 branches.

… date format (GH-123405) (#127829) gh-123401: Fix http.cookies module to support obsolete RFC 850 date format (GH-123405) (cherry picked from commit 359389e) Co-authored-by: Nano <nanoapezlk@gmail.com> Co-authored-by: Wulian <1055917385@qq.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>

… date format (GH-123405) (#127828) gh-123401: Fix http.cookies module to support obsolete RFC 850 date format (GH-123405) (cherry picked from commit 359389e) Co-authored-by: Nano <nanoapezlk@gmail.com> Co-authored-by: Wulian <1055917385@qq.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>

It seems everything is OK 🎉

…date format (python#123405) Co-authored-by: Wulian <1055917385@qq.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>

pythongh-123401 : Fix http.cookies module to support obsolete RFC 850 …

db912d8

…date format

bedevere-app Bot mentioned this pull request Aug 27, 2024

http.cookies module does not parse obsolete RFC 850 date format #123401

Closed

bedevere-app Bot added the awaiting review label Aug 27, 2024

Konano added 2 commits August 27, 2024 18:59

Add NEWS entry for http.cookies RFC 850 date format support

57904eb

Update NEWS entry to use double backticks for inline literals

d8cd225

Wulian233 reviewed Aug 28, 2024

View reviewed changes

Comment thread Lib/http/cookies.py Outdated

style(http/cookies): correct typo in regex comment

a373718

Fix a minor typo in the regex comment by adding a hyphen to "double-quoted" for consistency and clarity. No functional changes to the code logic. Co-authored-by: Wulian <1055917385@qq.com>

picnixz reviewed Sep 5, 2024

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2024-08-27-18-58-01.gh-issue-123401.t4-FpI.rst Outdated

Comment thread Lib/test/test_http_cookies.py

Konano and others added 2 commits September 6, 2024 01:32

Update Misc/NEWS.d/next/Library/2024-08-27-18-58-01.gh-issue-123401.t…

5cf347d

…4-FpI.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Include two examples from RFC 850

592da51

picnixz reviewed Sep 5, 2024

View reviewed changes

Comment thread Lib/test/test_http_cookies.py

Comment thread Misc/NEWS.d/next/Library/2024-08-27-18-58-01.gh-issue-123401.t4-FpI.rst

picnixz reviewed Sep 5, 2024

View reviewed changes

Comment thread Lib/test/test_http_cookies.py Outdated

Konano added 3 commits September 6, 2024 01:56

Add comments for rfc850 test cases

8cdf6c5

change EST to GMT in test cases

1692faf

Update Misc/NEWS.d/next/Library/2024-08-27-18-58-01.gh-issue-123401.t…

f9dd82b

…4-FpI.rst

vstinner approved these changes Sep 18, 2024

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 18, 2024

Merge branch 'main' into fix-issue-123401

b85efd7

vstinner enabled auto-merge (squash) December 11, 2024 13:06

vstinner merged commit 359389e into python:main Dec 11, 2024

bedevere-app Bot removed the awaiting merge label Dec 11, 2024

vstinner added the needs backport to 3.13 bugs and security fixes label Dec 11, 2024

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Dec 11, 2024

vstinner added the needs backport to 3.12 only security fixes label Dec 11, 2024

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 11, 2024

gh-123401: Fix http.cookies module to support obsolete RFC 850 date format by Konano · Pull Request #123405 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-123401: Fix http.cookies module to support obsolete RFC 850 date format - #123405

gh-123401: Fix http.cookies module to support obsolete RFC 850 date format#123405vstinner merged 10 commits intopython:mainpython/cpython:mainfrom Konano:fix-issue-123401Konano/cpython:fix-issue-123401Copy head branch name to clipboard

Conversation

Konano commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Aug 27, 2024 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app Bot commented Aug 27, 2024

Uh oh!

Uh oh!

Konano commented Sep 5, 2024

Uh oh!

Uh oh!

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Konano commented Sep 12, 2024

Uh oh!

Wulian233 commented Sep 12, 2024

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented Dec 11, 2024

Uh oh!

vstinner commented Dec 11, 2024

Uh oh!

Konano commented Dec 11, 2024

Uh oh!

miss-islington-app Bot commented Dec 11, 2024

Uh oh!

bedevere-app Bot commented Dec 11, 2024

Uh oh!

miss-islington-app Bot commented Dec 11, 2024

Uh oh!

bedevere-app Bot commented Dec 11, 2024

Uh oh!

vstinner commented Dec 11, 2024

Uh oh!

Konano commented Dec 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gh-123401: Fix http.cookies module to support obsolete RFC 850 date format#123405
vstinner merged 10 commits into
python:mainfrom
Konano:fix-issue-123401

Konano commented Aug 27, 2024 •
edited
Loading

ghost commented Aug 27, 2024 •
edited by ghost
Loading