Repository navigation
Use Kyiv instead of Kiev in test_email #109017
Description
Bug report
Bug description:
As proposed in #108533 the time zone was renamed but we can't simply rename it in the test cause it fails on old(?) MacOS systems. I would propose to prepend it with:
@unittest.skipUnless(os.path.exists('/usr/share/zoneinfo/Europe/Kyiv') or
os.path.exists('/usr/lib/zoneinfo/Europe/Kyiv'),
"Can't find the Olson's TZ database")CPython versions tested on:
3.11
Operating systems tested on:
Linux
Activity
corona10 commented on Sep 10, 2023
@serhiy-storchaka Would you like to take a look since you are the Ukranian?
Use non alternate name for Kyiv (Fixes: python#109017)
pythongh-109017: Use non alternate name for Kyiv
serhiy-storchaka commented on Sep 11, 2023
I do not like relying on the particular location of the database. Although it was already here in the existing code, the comment notes that it is not a robust way. Now we have zoneinfo in the stdlib, so perhaps it could be used.
pythongh-109017: Use non alternate name for Kyiv
jspricke commented on Sep 11, 2023
@serhiy-storchaka thanks for the proposal, I've updated my PR.
pythongh-109017: Use non alternate name for Kyiv
gh-109017: Use non alternate name for Kyiv (GH-109251)
pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)
pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)
[3.12] gh-109017: Use non alternate name for Kyiv (GH-109251) (GH-111280
[3.11] gh-109017: Use non alternate name for Kyiv (GH-109251) (GH-111279
pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)
pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)