FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-109017: Use non alternate name for Kyiv by jspricke · Pull Request #109251 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-109017: Use non alternate name for Kyiv - #109251

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
jspricke:fix_kyiv
Oct 24, 2023
ConversationCommits (5)ChecksFiles changed
Merged

gh-109017: Use non alternate name for Kyiv#109251
serhiy-storchaka merged 5 commits into
python:mainfrom
jspricke:fix_kyiv

Conversation

jspricke commented Sep 11, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.

jspricke requested a review from a team as a code owner September 11, 2023 04:43
bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Sep 11, 2023
bedevere-bot mentioned this pull request Sep 11, 2023
Closed
serhiy-storchaka self-assigned this Sep 11, 2023
serhiy-storchaka reviewed Sep 11, 2023
View reviewed changes
Comment thread Lib/test/test_email/test_utils.py Outdated
pythongh-109017: Use non alternate name for Kyiv
b10798b 
tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
serhiy-storchaka reviewed Sep 11, 2023
View reviewed changes
Comment thread Lib/test/test_email/test_utils.py Outdated

serhiy-storchaka commented Sep 11, 2023

Copy link
Copy Markdown
Member

Very well. Tested on Windows, so the check works.

Now I'm waiting for our buildbots to be fixed (they're not very stable at the moment), then I'll run tests with this PR on the buildbots, and if they pass, I'll merge the PR.

serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 12, 2023

bedevere-bot commented Sep 12, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit d12532a 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 12, 2023
AA-Turner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 21, 2023

bedevere-bot commented Sep 21, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @AA-Turner for commit 496d9c3 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 21, 2023
serhiy-storchaka removed the request for review from a team October 24, 2023 07:42
serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 24, 2023

bedevere-bot commented Oct 24, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit fff7bb4 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 24, 2023
serhiy-storchaka merged commit 46407fe into python:main Oct 24, 2023
serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 24, 2023

miss-islington-app Bot commented Oct 24, 2023

Copy link
Copy Markdown

Thanks @jspricke for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington-app Bot commented Oct 24, 2023

Copy link
Copy Markdown

Thanks @jspricke for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2023
pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)
59db316 
tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
(cherry picked from commit 46407fe)

Co-authored-by: Jochen Sprickerhof <github@jochen.sprickerhof.de>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2023
pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)
1b56294 
tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
(cherry picked from commit 46407fe)

Co-authored-by: Jochen Sprickerhof <github@jochen.sprickerhof.de>

bedevere-app Bot commented Oct 24, 2023

Copy link
Copy Markdown

GH-111279 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Oct 24, 2023

bedevere-app Bot commented Oct 24, 2023

Copy link
Copy Markdown

GH-111280 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 24, 2023
serhiy-storchaka pushed a commit that referenced this pull request Oct 24, 2023
[3.12] gh-109017: Use non alternate name for Kyiv (GH-109251) (GH-111280
b6e508c 
)

tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
(cherry picked from commit 46407fe)

Co-authored-by: Jochen Sprickerhof <github@jochen.sprickerhof.de>
serhiy-storchaka pushed a commit that referenced this pull request Oct 24, 2023
[3.11] gh-109017: Use non alternate name for Kyiv (GH-109251) (GH-111279
652d3f3 
)

tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
(cherry picked from commit 46407fe)

Co-authored-by: Jochen Sprickerhof <github@jochen.sprickerhof.de>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)
ac32394 
tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
stefanor mentioned this pull request Aug 30, 2024
Merged
mattip pushed a commit to pypy/pypy that referenced this pull request Aug 30, 2024
Use Kyiv instead of Kiev
c30af4d 
tzdata provides Kiev as an alternative to Kyiv, but Debian moved it to
the tzdata-legacy package, breaking these tests.

cPython also uses this timezone in test_email, and this was fixed in
3.11. I've left that patch out of here, it will get picked up when PyPy
switches to 3.11 stdlib.

python/cpython#109251
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)
8fbaa03 
tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
serhiy-storchaka removed their assignment Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka left review comments

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL