FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Implement PEP 765 · Issue #130080 · python/cpython · GitHub

Repository navigation

Implement PEP 765 #130080

Closed
Closed

Activity

  1. self-assigned this
    on Feb 13, 2025
  2. added 3 commits that reference this issue on Feb 13, 2025
  3. added 2 commits that reference this issue on Feb 16, 2025
  4. added 2 commits that reference this issue on Mar 6, 2025
  5. added a commit that references this issue on Mar 17, 2025
  6. added a commit that references this issue on Mar 17, 2025
  7. hugovk commented on Mar 17, 2025

    Member

    🚀

    Final task, mark the the PEP as Final:

    Once a PEP has been accepted, the reference implementation must be completed. When the reference implementation is complete and incorporated into the main source code repository, the status will be changed to “Final”.

    https://peps.python.org/pep-0001/#pep-review-resolution

  8. picnixz commented on Mar 18, 2025

    Member

    There are a bunch of warnings when executing the test suite now:

    I'm re-opening the issue so that we fix the issues in the tests but you can open a separate issue if you want.

  9. 4 remaining items

  10. added 3 commits that reference this issue on Mar 19, 2025
  11. added 2 commits that reference this issue on Mar 20, 2025
  12. cdce8p commented on Mar 22, 2025

    Contributor

    #130087 seems to have introduce a regression were AST folding is now applied even if it shouldn't be. E.g.

    # test.py
    match a:
      case -1+2j:
        pass

    With Python 3.13 (or 3.14a6)

    $ python3.13 -m ast test.py
            ...
                match_case(
                   pattern=MatchValue(
                      value=BinOp(
                         left=UnaryOp(
                            op=USub(),
                            operand=Constant(value=1)),
                         op=Add(),
                         right=Constant(value=2j))),
                   body=[...
    

    After #130087

    $ python -m ast test.py
            ...
                match_case(
                   pattern=MatchValue(
                      value=Constant(value=(-1+2j))),
                   body=[...
    
  13. added 2 commits that reference this issue on Mar 22, 2025
  14. iritkatriel commented on Mar 23, 2025

    MemberAuthor

    #130087 seems to have introduce a regression were AST folding is now applied even if it shouldn't be. E.g.

    Thanks, this is now fixed.

  15. WolframAlph commented on Mar 25, 2025

    Contributor

    @iritkatriel I believe this memset is unnecessary:

    memset(&state, 0, sizeof(_PyASTOptimizeState));

    Here is PR: #131745

  16. iritkatriel commented on Mar 25, 2025

    MemberAuthor

    We do this in other places - set everything to 0 and then override other fields. If someone adds a new field which should be initialised to 0 they will probably not bother to update initialisation.

  17. WolframAlph commented on Mar 28, 2025

    Contributor

    I see. Closing it then.

  18. defkev commented on Oct 10, 2025

    I just upgraded to 3.14 (from 3.13) and now I can no longer return a custom value from a function when returning early without copy and pasting my return value everywhere?

    def test(fail = False):
        try:
            if fail:
                raise Exception('fail')
            else:
                print('try')
                return # Will never reach Done
        except Exception as e:
            print(e)
        finally:
            print('Finally')
            return (0, 1, 2) # Syntaxerror in 3.14
        print('Done')
        return (0, 1, 2) # Unreachable when returning early

    Who tf comes up with this nonsense?!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancement

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


    Back | FazBrowse Home | New Git URL