FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-133379: Correct usage of `arguments` in error messages by StanFromIreland · Pull Request #133382 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-133379: Correct usage of arguments in error messages - #133382

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
StanFromIreland:correct-errors
May 10, 2025
ConversationCommits (5)ChecksFiles changed
Merged

gh-133379: Correct usage of arguments in error messages#133382
serhiy-storchaka merged 5 commits into
python:mainfrom
StanFromIreland:correct-errors

Conversation

StanFromIreland commented May 4, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Not quite sure what the title should be for this.

bedevere-app Bot mentioned this pull request May 4, 2025
Closed
JelleZijlstra approved these changes May 4, 2025
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Title looks great to me

picnixz commented May 4, 2025

Copy link
Copy Markdown
Member

The title could be about correcting the places where the term argument is incorrectly used, but your title is fine.

picnixz mentioned this pull request May 9, 2025
Closed

serhiy-storchaka commented May 9, 2025

Copy link
Copy Markdown
Member

What is the difference between #133382 and #133463?

StanFromIreland commented May 9, 2025

Copy link
Copy Markdown
Member Author

Other error messages are corrected.

picnixz commented May 9, 2025

Copy link
Copy Markdown
Member

Following #133463 (comment), I suggest we fix everything here.

StanFromIreland commented May 9, 2025

Copy link
Copy Markdown
Member Author

All complete, I included @serhiy-storchaka extra example and two more I found. Added an entry to whatsnew since this affects quite a few error messages.

serhiy-storchaka approved these changes May 10, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. 👍

serhiy-storchaka merged commit dbca27c into python:main May 10, 2025
StanFromIreland deleted the correct-errors branch May 10, 2025 12:02
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-133379: Fix misuse of the term "arguments" in error messages (…
332d44c 
…pythonGH-133382)

The right term is "parameters".
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-133379: Fix misuse of the term "arguments" in error messages (…
3e82f21 
…pythonGH-133382)

The right term is "parameters".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
serhiy-storchaka serhiy-storchaka approved these changes
picnixz picnixz approved these changes
pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
ambv Awaiting requested review from ambv ambv is a code owner
carljm Awaiting requested review from carljm carljm is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL