FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-133436: Correct error messages that incorrectly use "arguments" by StanFromIreland · Pull Request #133463 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-133436: Correct error messages that incorrectly use "arguments" - #133463

Closed
StanFromIreland wants to merge 2 commits into
python:mainfrom
StanFromIreland:marker-err
ConversationCommits (2)ChecksFiles changed
Closed

gh-133436: Correct error messages that incorrectly use "arguments"#133463
StanFromIreland wants to merge 2 commits into
python:mainfrom
StanFromIreland:marker-err

Conversation

StanFromIreland commented May 5, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request May 5, 2025
Closed
StanFromIreland commented May 5, 2025
View reviewed changes
Comment thread Grammar/python.gram
| '*' param a='=' { RAISE_SYNTAX_ERROR_KNOWN_LOCATION(a, "var-positional argument cannot have default value") }
| '*' (param_no_default | ',') param_maybe_default* a='*' (param_no_default | ',') {
RAISE_SYNTAX_ERROR_KNOWN_LOCATION(a, "* argument may appear only once") }
RAISE_SYNTAX_ERROR_KNOWN_LOCATION(a, "* marker may appear only once") }

StanFromIreland May 5, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I liked @picnixz suggestion though there may be an even better word?

Kivooeo May 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

imo, "an asterisk may appear only once" is as clear as possible and will not cause any confusion in terms of terminology

serhiy-storchaka May 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Other error messages refer to / as just / and to * as just *. On other hand, * marker can be confused with bare *. So I think that it is better to use just * here.

serhiy-storchaka reviewed May 9, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There are more:

    def f(/, *a, b): pass
          ^
SyntaxError: at least one argument must precede /

    def f(**a, b): pass
               ^
SyntaxError: arguments cannot follow var-keyword argument

serhiy-storchaka reviewed May 9, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

More examples:

    def f(/, a, /, b): pass
          ^
SyntaxError: at least one argument must precede /

    def f(a, a): pass
             ^
SyntaxError: duplicate argument 'a' in function definition

Comment thread Grammar/python.gram
| '*' param a='=' { RAISE_SYNTAX_ERROR_KNOWN_LOCATION(a, "var-positional argument cannot have default value") }
| '*' (param_no_default | ',') param_maybe_default* a='*' (param_no_default | ',') {
RAISE_SYNTAX_ERROR_KNOWN_LOCATION(a, "* argument may appear only once") }
RAISE_SYNTAX_ERROR_KNOWN_LOCATION(a, "* marker may appear only once") }

serhiy-storchaka May 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Other error messages refer to / as just / and to * as just *. On other hand, * marker can be confused with bare *. So I think that it is better to use just * here.

picnixz commented May 9, 2025

Copy link
Copy Markdown
Member

The rest is in #133382, but maybe we can do all in one PR? I suggested two because of semantics, but maybe it's better to do everything at once (in this case, let's use #133382 instead and close the other issue as well)

serhiy-storchaka mentioned this pull request May 9, 2025
Merged

serhiy-storchaka commented May 9, 2025

Copy link
Copy Markdown
Member

I suggest to do all in one PR. I do not see semantic difference. There are other error messages that need corrections, see my examples.

picnixz commented May 9, 2025

Copy link
Copy Markdown
Member

I'll close this one and the corresponding issue. We'll work with one issue and one PR instead.

picnixz closed this May 9, 2025
StanFromIreland deleted the marker-err branch May 9, 2025 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka left review comments
pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
+1 more reviewer
Kivooeo Kivooeo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL