Repository navigation
Adjust _Py_MAX_MANAGED_STATIC_BUILTIN_TYPES value automatically #145497
Description
When a new built-in type is introduced, _Py_MAX_MANAGED_STATIC_BUILTIN_TYPES needs to be updated accordingly.
(e.g., 3e2f5c1, #145496 (comment))
This is quite painful, and sometimes we even forget to adjust it. To prevent this kind of issue, we may need a way to update it automatically, or add a test that verifies it is set correctly.
cc @markshannon @Fidget-Spinner @vstinner
Activity
vstinner commented on Mar 4, 2026
How do you want to compute _Py_MAX_MANAGED_STATIC_BUILTIN_TYPES value?
The static_types array in Objects/object.c only has 118 entries (where _PyUOpExecutor_Type is only available if _Py_TIER2 macro is defined), whereas _Py_MAX_MANAGED_STATIC_BUILTIN_TYPES is equal to 201 (it should be 202, PR gh-145496 fix it). So I don't see the direct relationship between static_types and _Py_MAX_MANAGED_STATIC_BUILTIN_TYPES.
corona10 commented on Mar 4, 2026
I don't think about it concretely, but I believe that we need to find a better way.
ZeroIntensity commented on Apr 29, 2026
Another example of this causing issues: #149121. At the very least, it would be nice to have a test that verified the number, so we don't run into weird issues on the main branch when we forget to fix it.
Hm, what is _Py_MAX_MANAGED_STATIC_BUILTIN_TYPES if not the length of static_types? Where do the other ~80 entries come from?
JelleZijlstra commented on Apr 29, 2026
Seems the rest are mostly exception classes and a few others that aren't in static_types itself.
Here's a list from printing every type that gets added:
static.txt
encukou commented on Apr 29, 2026
See also #149121.
gh-145497: Use same size of static_types array in all builds (GH-149139)
StanFromIreland commented on May 2, 2026
Triage: with #149139 merged, can this be closed?
StanFromIreland commented on May 2, 2026
Ooops wrong button.
corona10 commented on May 2, 2026
Yes we can close! Thank you @encukou
encukou commented on May 4, 2026
Sadly, that PR is just a workaround. It would still be nice to adjust this automatically.
pythongh-145497: Check _Py_NUM_MANAGED_STATIC_EXTRA_TYPES at runtime
pythongh-145497: Check _Py_NUM_MANAGED_STATIC_EXTRA_TYPES at runtime
vstinner commented on Sep 15, 2026
Please see my new PR gh-157582 which actually counts static types at Python startup (in debug mode) to make sure that macros are still up to date.