Repository navigation
gh-145497: Use same size of static_types array in all builds - #149139
encukou merged 6 commits into
Conversation
Sorry, something went wrong.
When someone adds a new type but doesn't increment `_Py_MAX_MANAGED_STATIC_BUILTIN_TYPES` or `_Py_MAX_MANAGED_STATIC_EXT_TYPES`, JIT tests fail, because JIT builds define an extra type. But the JIT tests don't necessarily run for the commit that causes the failure. As a workaround, use the same size for the array for all builds, potentially with an empty spot.
Documentation build overview53 files changed · ± 52 modified · - 1 deleted ± Modified
- Deleted |
Sorry, something went wrong.
|
Why not :) |
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
ZeroIntensity
left a comment
There was a problem hiding this comment.
LGTM as well.
To be clear: If we forget to update _Py_MAX_MANAGED_STATIC_BUILTIN_TYPES from now on, it won't be possible to merge the PR, right? (If not, that's fine -- I think we should do this regardless.)
Sorry, something went wrong.
Correct. If you add an entry to static_types without updating _Py_MAX_MANAGED_STATIC_BUILTIN_TYPES, you get a compiler error and so the PR cannot be merged. |
Sorry, something went wrong.
| @@ -531,7 +531,9 @@ struct _py_func_state { | |||
|
|
|||
| /* For now we hard-code this to a value for which we are confident | |||
| all the static builtin types will fit (for all builds). */ | |||
There was a problem hiding this comment.
The 83 still needs to be bumped if you add some categories of new types, right?
Would be useful to rewrite the comment to something like "If you add a new type, you may have to update some of these numbers".
Sorry, something went wrong.
There was a problem hiding this comment.
Sure.
(I don't think it will be that helpful though -- if you're reading this piece of code, you probably already know. But it's nice to get a confirmation.)
Sorry, something went wrong.
When someone adds a new type but doesn't increment _Py_MAX_MANAGED_STATIC_BUILTIN_TYPES or
_Py_MAX_MANAGED_STATIC_EXT_TYPES, JIT tests fail, because JIT builds define an extra type.
But the JIT tests don't necessarily run for the commit that causes the failure,
so the issue only shows up in subsequent PR(s) that touch the JIT.
As a workaround, use the same size for the array for all builds, potentially with an empty spot.