FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[doc] Clarify bytes vs text with non-seeking tarfile stream · Issue #67641 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[doc] Clarify bytes vs text with non-seeking tarfile stream #67641

Closed
Closed
[doc] Clarify bytes vs text with non-seeking tarfile stream#67641
Labels
3.10 (EOL)end of life3.11only security fixes3.9 (EOL)end of lifedocsDocumentation in the Doc direasystdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

Description

chaica
mannequin
opened on Feb 12, 2015
BPO 23453
Nosy @vadmium, @slateny
PRs
  • gh-67641: Clarify documentation on bytes vs text with non-seeking tarfile stream #31610
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2015-02-12.11:19:58.435>
labels = ['easy', 'type-bug', '3.9', '3.10', '3.11', 'library', 'docs']
title = '[doc] Clarify bytes vs text with non-seeking tarfile stream'
updated_at = <Date 2022-02-28.08:40:18.686>
user = 'https://bugs.python.org/chaica'

    bugs.python.org fields:

    activity = <Date 2022-02-28.08:40:18.686>
actor = 'slateny'
assignee = 'docs@python'
closed = False
closed_date = None
closer = None
components = ['Documentation', 'Library (Lib)']
creation = <Date 2015-02-12.11:19:58.435>
creator = 'chaica_'
dependencies = []
files = []
hgrepos = []
issue_num = 23453
keywords = ['patch', 'easy']
message_count = 3.0
messages = ['235808', '235810', '264459']
nosy_count = 4.0
nosy_names = ['chaica_', 'docs@python', 'martin.panter', 'slateny']
pr_nums = ['31610']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue23453'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    Linked PRs

    Activity

    1. chaica commented on Feb 12, 2015

      chaicamannequin
      on Feb 12, 2015
      MannequinAuthor

      I'm trying to use a tar stream to a Python tarfile object but each time I do have a TypeError: can't concat bytes to str error

      Here is my test:
      -----8<-----
      #!/usr/bin/python3.4

      import tarfile
import sys

tarobj = tarfile.open(mode='r|', fileobj=sys.stdin)
print(tarobj)
tarobj.close()
-----8<
      $ tar cvf test.tar.gz tests/
tests/
tests/foo1
tests/foo/
tests/foo/bar
$ tar -O -xvf test.tar | ./tarstream.py
tests/
tests/foo1
tests/foo/
tests/foo/bar
Traceback (most recent call last):
  File "./tarstream.py", line 6, in <module>
    tarobj = tarfile.open(mode='r|', fileobj=sys.stdin)
  File "/usr/lib/python3.4/tarfile.py", line 1578, in open
    t = cls(name, filemode, stream, **kwargs)
  File "/usr/lib/python3.4/tarfile.py", line 1470, in __init__
    self.firstmember = self.next()
  File "/usr/lib/python3.4/tarfile.py", line 2249, in next
    tarinfo = self.tarinfo.fromtarfile(self)
  File "/usr/lib/python3.4/tarfile.py", line 1082, in fromtarfile
    buf = tarfile.fileobj.read(BLOCKSIZE)
  File "/usr/lib/python3.4/tarfile.py", line 535, in read
    buf = self._read(size)
  File "/usr/lib/python3.4/tarfile.py", line 543, in _read
    return self.__read(size)
  File "/usr/lib/python3.4/tarfile.py", line 569, in __read
    self.buf += buf
TypeError: can't concat bytes to str

      Regards,
      Carl Chenet

    2. chaica
      added
      type-crashA hard crash of the interpreter, possibly with a core dump
      stdlibStandard Library Python modules in the Lib/ directory
      on Feb 12, 2015

    3. vadmium commented on Feb 12, 2015

      vadmium
      on Feb 12, 2015
      Member

      Using fileobj=sys.stdin.buffer instead should do the trick. The “tarfile” module would expect a binary stream, not a text stream.

      Given the documentation currently says, “Use this variant in combination with e.g. sys.stdin, . . .”, I presume that is why you were using plain stdin. The documentation should be clarified.

    4. vadmium
      added
      docsDocumentation in the Doc dir
      on Feb 12, 2015
    5. vadmium
      assigned
      docspython
      on Feb 12, 2015
    6. vadmium
      added
      type-bugAn unexpected behavior, bug, or error
      and removed
      type-crashA hard crash of the interpreter, possibly with a core dump
      on Feb 9, 2016

    7. vadmium commented on Apr 29, 2016

      vadmium
      on Apr 29, 2016
      Member

      Looks like the _Stream docstring needs a similar fix regarding stdin and stdout. Also, it wouldn’t hurt to specify that the read() and write() methods should work with bytes, not text.

    8. vadmium
      changed the title [-]Opening a stream with tarfile.open() triggers a TypeError: can't concat bytes to str error[/-] [+]Clarify bytes vs text with non-seeking tarfile stream[/+] on Apr 29, 2016
    9. iritkatriel
      added
      easy
      3.9 (EOL)end of life
      3.10 (EOL)end of life
      3.11only security fixes
      on Dec 1, 2021
    10. iritkatriel
      changed the title [-]Clarify bytes vs text with non-seeking tarfile stream[/-] [+][doc] Clarify bytes vs text with non-seeking tarfile stream[/+] on Dec 1, 2021
    11. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    12. serhiy-storchaka
      added this to Tarfile issues 🗄️on May 20, 2022
    13. serhiy-storchaka
      added a commit that references this issue on Dec 27, 2023

      gh-67641: Clarify documentation on bytes vs text with non-seeking tar…

      0651936
    14. miss-islington
      added 2 commits that reference this issue on Dec 27, 2023

      pythongh-67641: Clarify documentation on bytes vs text with non-seeki…

      99674ab

      pythongh-67641: Clarify documentation on bytes vs text with non-seeki…

      783fa27
    15. serhiy-storchaka
      closed this as completedon Dec 27, 2023
    16. github-project-automation
      moved this to Done in Tarfile issues 🗄️on Dec 27, 2023
    17. serhiy-storchaka
      added 2 commits that reference this issue on Dec 27, 2023

      [3.12] gh-67641: Clarify documentation on bytes vs text with non-seek…

      72410a3

      [3.11] gh-67641: Clarify documentation on bytes vs text with non-seek…

      f9d25b5
    18. kulikjak
      added a commit that references this issue on Jan 22, 2024

      pythongh-67641: Clarify documentation on bytes vs text with non-seeki…

      73b58bb
    19. aisk
      added a commit that references this issue on Feb 11, 2024

      pythongh-67641: Clarify documentation on bytes vs text with non-seeki…

      6991942
    20. Glyphack
      added a commit that references this issue on Sep 2, 2024

      pythongh-67641: Clarify documentation on bytes vs text with non-seeki…

      5796b03
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.10 (EOL)end of life3.11only security fixes3.9 (EOL)end of lifedocsDocumentation in the Doc direasystdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

      Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      Back | FazBrowse Home | New Git URL