FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-91928: Add `datetime.UTC` alias for `datetime.timezone.utc` by Kab1r · Pull Request #91973 · python/cpython · GitHub

/ cpython Public

gh-91928: Add datetime.UTC alias for datetime.timezone.utc - #91973

Merged
miss-islington merged 8 commits into
python:mainfrom
Kab1r:feat-datetime-utc-alias
May 3, 2022
ConversationCommits (8)ChecksFiles changed
Merged

gh-91928: Add datetime.UTC alias for datetime.timezone.utc#91973
miss-islington merged 8 commits into
python:mainfrom
Kab1r:feat-datetime-utc-alias

Conversation

Kab1r commented Apr 27, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

fixes #91928

UTC is now module attribute aliased to datetime.timezone.utc.
You can now do the following:

from datetime import UTC

Automerge-Triggered-By: GH:pganssle

Kab1r requested review from abalkin and pganssle as code owners April 27, 2022 00:59

ghost commented Apr 27, 2022 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-bot commented Apr 27, 2022

Copy link
Copy Markdown

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

pganssle requested changes Apr 27, 2022
View reviewed changes

pganssle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks great, thanks!

In addition to my other comments, two other things:

  1. As I believe you are a first-time contributor, you should probably add your name to Misc/ACKS.
  2. Maybe add a very simple test to TestModule, like this:
def test_utc_alias(self):
    self.assertIs(UTC, timezone.utc)

Thanks for your contribution!

Comment thread Misc/NEWS.d/next/Library/2022-04-26-18-02-44.gh-issue-91928.V0YveU.rst Outdated
Comment thread Doc/library/datetime.rst Outdated
Comment thread Doc/library/datetime.rst Outdated

bedevere-bot commented Apr 27, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

pganssle mentioned this pull request Apr 27, 2022
Closed

Kab1r commented Apr 27, 2022

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-bot commented Apr 27, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

bedevere-bot requested a review from pganssle April 27, 2022 20:41
pganssle requested changes Apr 27, 2022
View reviewed changes

pganssle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add this test?

Maybe add a very simple test to TestModule, like this:

    def test_utc_alias(self):
       self.assertIs(UTC, timezone.utc)

Comment thread Doc/library/datetime.rst Outdated

bedevere-bot commented Apr 27, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Kab1r commented Apr 27, 2022

Copy link
Copy Markdown
Contributor Author

I had to move the definition of datetime.UTC to the end so that modifications to datetime.timezone.utc doesn't make it a different object.

Kab1r commented Apr 27, 2022

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-bot commented Apr 27, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

bedevere-bot requested a review from pganssle April 27, 2022 22:20
Kab1r and others added 4 commits May 3, 2022 14:02
docs(datetime): add versionadded to datetime.UTC
1e8257d
test(datetime): add test for datetime.UTC alias
7335f0a
fix(datetime): move datetime.UTC definition to end to ensure that i…
185c7ac 
…t is an alias
Clean up nits
9542f54 
1. Add UTC definition into C implementation as well (just for
   consistency, there's no particular reason not to simply assign the
   alias in the Python code later).

2. Move `..versionadded` tag into the right place
pganssle force-pushed the feat-datetime-utc-alias branch from c097669 to 9542f54 Compare May 3, 2022 20:02
miss-islington merged commit 48c6165 into python:main May 3, 2022

pganssle commented May 3, 2022

Copy link
Copy Markdown
Member

Thanks @Kab1r!

dignissimus mentioned this pull request May 4, 2022
Merged
jopemachine mentioned this pull request Sep 9, 2022
Merged
natoscott added a commit to natoscott/pcp that referenced this pull request May 8, 2025
pmseries_import: use a datetime UTC interface from python3.6
e056732 
Resolves an issue Ken reported running tests in the QA farm,
which is due to use of an interface from more-recent-python:
python/cpython#91973
natoscott mentioned this pull request May 8, 2025
Merged
Shixiaowei02 mentioned this pull request May 16, 2025
Merged
coderabbitai Bot mentioned this pull request Mar 24, 2026
Merged
This was referenced Apr 17, 2026
Merged
Merged
This was referenced Jun 4, 2026
Merged
Merged
coderabbitai Bot mentioned this pull request Jun 18, 2026
Merged
coderabbitai Bot mentioned this pull request Jul 25, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pganssle pganssle approved these changes
abalkin Awaiting requested review from abalkin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add datetime.UTC alias for datetime.timezone.utc

4 participants

Back | FazBrowse Home | New Git URL